r102242 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102241‎ | r102242 | r102243 >
Date:03:30, 7 November 2011
Author:kaldari
Status:ok
Tags:
Comment:
hardcoding country for lightbox forms, using correct selector for state
Modified paths:
  • /trunk/extensions/DonationInterface/globalcollect_gateway/forms/js/lightbox1.js (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/js/lightbox1.js (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/js/lightbox1.js
@@ -150,7 +150,6 @@
151151 )
152152
153153 /* Submit the form */
154 - /* TODO: Replace this with AJAX request */
155154 var sendData = {
156155 'action': 'donate',
157156 'gateway': 'payflowpro',
@@ -160,10 +159,10 @@
161160 'lname': $( "input[name='lname']" ).val(),
162161 'street': $( "input[name='street']" ).val(),
163162 'city': $( "input[name='city']" ).val(),
164 - 'state': $( "input[name='state']" ).val(),
 163+ 'state': $( 'select#state option:selected' ).val(),
165164 'zip': $( "input[name='zip']" ).val(),
166165 'emailAdd': $( "input[name='emailAdd']" ).val(),
167 - 'country': $( "input[name='country']" ).val(),
 166+ 'country': 'US',
168167 'payment_method': 'cc',
169168 'language': 'en',
170169
Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/js/lightbox1.js
@@ -141,7 +141,6 @@
142142 $( "input[name='country']" ).val('US' );
143143
144144 /* Submit the form */
145 - /* TODO: Replace this with AJAX request */
146145 var sendData = {
147146 'action': 'donate',
148147 'gateway': 'globalcollect',
@@ -151,10 +150,10 @@
152151 'lname': $( "input[name='lname']" ).val(),
153152 'street': $( "input[name='street']" ).val(),
154153 'city': $( "input[name='city']" ).val(),
155 - 'state': $( "input[name='state']" ).val(),
 154+ 'state': $( 'select#state option:selected' ).val(),
156155 'zip': $( "input[name='zip']" ).val(),
157156 'emailAdd': $( "input[name='emailAdd']" ).val(),
158 - 'country': $( "input[name='country']" ).val(),
 157+ 'country': 'US',
159158 'payment_method': 'cc',
160159 'language': 'en',
161160 'card_type': 'visa',

Follow-up revisions

RevisionCommit summaryAuthorDate
r102245MFT r102241, r102242awjrichards03:33, 7 November 2011

Status & tagging log