r102044 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r102043‎ | r102044 | r102045 >
Date:20:40, 4 November 2011
Author:khorn
Status:ok
Tags:
Comment:
The redirection actually takes place just fine on the outside of this function... and the failpage string already gets built (with language and everything) on the inside of the adapter. Trying to redirect in here wasn't taking us anywhere.
r101576
Also: r102042, because this was fixed in deployment before trunk, for efficiency reasons.
Modified paths:
  • /trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect_resultswitcher.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect_resultswitcher.body.php
——@@ -107,10 +107,10 @@
108108 global $wgOut;
109109
110110 $displayData = $this->adapter->getData_Raw();
111 - $failpage = $this->adapter->getGlobal( 'FailPage' );
 111+ $failpage = $this->adapter->getFailPage();
112112
113113 if ( $failpage ) {
114 - $wgOut->redirect( $failpage . "/" . $displayData['language'] );
 114+ return $failpage;
115115 } else {
116116 // Get the page we're going to send them back to.
117117 $referrer = $displayData['referrer'];

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101576begining to handle transaction errors for globalcollect - this might be all w...kaldari02:22, 2 November 2011
r102042Live bugfix to deployment, so we can redirect to the generic fail page on a g...khorn20:29, 4 November 2011

Status & tagging log