r102042 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102041‎ | r102042 | r102043 >
Date:20:29, 4 November 2011
Author:khorn
Status:ok
Tags:
Comment:
Live bugfix to deployment, so we can redirect to the generic fail page on a globalcollect transaction gone wrong.
Modified paths:
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/globalcollect_resultswitcher.body.php (modified) (history)

Diff [purge]

Index: branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/globalcollect_resultswitcher.body.php
@@ -105,10 +105,10 @@
106106 global $wgOut;
107107
108108 $displayData = $this->adapter->getDisplayData();
109 - $failpage = $this->adapter->getGlobal( 'FailPage' );
 109+ $failpage = $this->adapter->getFailPage();
110110
111111 if ( $failpage ) {
112 - $wgOut->redirect( $failpage . "/" . $displayData['language'] );
 112+ return $failpage;
113113 } else {
114114 // Get the page we're going to send them back to.
115115 $referrer = $displayData['referrer'];

Follow-up revisions

RevisionCommit summaryAuthorDate
r102044The redirection actually takes place just fine on the outside of this functio...khorn20:40, 4 November 2011

Status & tagging log