r101989 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101988‎ | r101989 | r101990 >
Date:13:08, 4 November 2011
Author:mah
Status:ok (Comments)
Tags:
Comment:
eol w/s
Modified paths:
  • /trunk/phase3/resources/mediawiki.action/mediawiki.action.edit.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki.action/mediawiki.action.edit.js
@@ -1,11 +1,11 @@
22 (function( $ ) {
33 // currentFocus is used to determine where to insert tags
44 var currentFocused = $( '#wpTextbox1' );
5 -
 5+
66 mw.toolbar = {
77 $toolbar : $( '#toolbar' ),
88 buttons : [],
9 - // If you want to add buttons, use
 9+ // If you want to add buttons, use
1010 // mw.toolbar.addButton( imageFile, speedTip, tagOpen, tagClose, sampleText, imageId, selectText );
1111 addButton : function() {
1212 this.buttons.push( [].slice.call( arguments ) );
@@ -36,7 +36,7 @@
3737 'encapsulateSelection', { 'pre': tagOpen, 'peri': sampleText, 'post': tagClose }
3838 );
3939 }
40 - },
 40+ },
4141 init : function() {
4242 // Legacy
4343 // Merge buttons from mwCustomEditButtons
@@ -61,7 +61,7 @@
6262
6363 //make sure edit summary does not exceed byte limit
6464 $( '#wpSummary' ).byteLimit( 250 );
65 -
 65+
6666 $( document ).ready( function() {
6767 /**
6868 * Restore the edit box scroll state following a preview operation,
@@ -81,10 +81,10 @@
8282 }
8383 };
8484 scrollEditBox();
85 -
 85+
8686 // Create button bar
8787 mw.toolbar.init();
88 -
 88+
8989 $( '#wpSummary, #wpTextbox1' ).focus( function() {
9090 currentFocused = $(this);
9191 });

Comments

#Comment by Siebrand (talk | contribs)   20:59, 10 November 2011

Why on earth would this break unit tests? http://toolserver.org/~krinkle/testswarm/user/MediaWiki/

#Comment by Reedy (talk | contribs)   21:04, 10 November 2011

Co-incidence? Some sort of local conflict?

Status & tagging log