r101922 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101921‎ | r101922 | r101923 >
Date:00:02, 4 November 2011
Author:raindrift
Status:ok (Comments)
Tags:
Comment:
jumpy scrolling behavior came back. fixed again: moveToStep now only does things if there are things to do.
Modified paths:
  • /trunk/extensions/UploadWizard/resources/mw.UploadWizard.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/resources/mw.UploadWizard.js
@@ -358,6 +358,11 @@
359359 moveToStep: function( selectedStepName, callback ) {
360360 var _this = this;
361361
 362+ if( _this.currentStepName === selectedStepName ) {
 363+ // already there!
 364+ return;
 365+ }
 366+
362367 // scroll to the top of the page (the current step might have been very long, vertically)
363368 $j( 'html, body' ).animate( { scrollTop: 0 }, 'slow' );
364369

Comments

#Comment by NeilK (talk | contribs)   00:10, 4 November 2011

good enough for now, although this problem must be due to calling moveToStep from the wrong place...

Status & tagging log