r101896 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101895‎ | r101896 | r101897 >
Date:22:21, 3 November 2011
Author:aaron
Status:resolved (Comments)
Tags:lamecommitsummary 
Comment:
FU r96015: removed & in MakeGlobalVariablesScript hook
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -2692,7 +2692,7 @@
26932693 // Use the 'ResourceLoaderGetConfigVars' hook if the variable is not
26942694 // page-dependant but site-wide (without state).
26952695 // Alternatively, you may want to use OutputPage->addJsConfigVars() instead.
2696 - wfRunHooks( 'MakeGlobalVariablesScript', array( &$vars, &$this ) );
 2696+ wfRunHooks( 'MakeGlobalVariablesScript', array( &$vars, $this ) );
26972697
26982698 // Merge in variables from addJsConfigVars last
26992699 return array_merge( $vars, $this->mJsConfigVars );

Follow-up revisions

RevisionCommit summaryAuthorDate
r101997Updated docs for r101896aaron15:05, 4 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96015Pass OutputPage instance to MakeGlobalVariablesScript. Allows extensions to g...krinkle17:23, 1 September 2011

Comments

#Comment by Nikerabbit (talk | contribs)   11:24, 4 November 2011

Docs not changed?

Status & tagging log