r101866 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101865‎ | r101866 | r101867 >
Date:20:01, 3 November 2011
Author:tparscal
Status:deferred
Tags:
Comment:
Renamed expandContentData to getExpandedContentData
Modified paths:
  • /trunk/extensions/VisualEditor/modules/es/bases/es.DocumentModelNode.js (modified) (history)
  • /trunk/extensions/VisualEditor/modules/es/models/es.DocumentModel.js (modified) (history)
  • /trunk/extensions/VisualEditor/modules/es/serializers/es.HtmlSerializer.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/modules/es/models/es.DocumentModel.js
@@ -488,7 +488,7 @@
489489 * @method
490490 * @returns {Object} Plain object representation
491491 */
492 -es.DocumentModel.expandContentData = function( data ) {
 492+es.DocumentModel.getExpandedContentData = function( data ) {
493493 var stack = [];
494494 // Text and annotations
495495 function start( offset, annotation ) {
Index: trunk/extensions/VisualEditor/modules/es/serializers/es.HtmlSerializer.js
@@ -38,6 +38,21 @@
3939 return count ? htmlAttributes : null;
4040 };
4141
 42+es.HtmlSerializer.getExpandedListItems = function( node ) {
 43+ var styles,
 44+ levels = [];
 45+ for ( var i = 0; i < this.children.length; i++ ) {
 46+ styles = this.children[i].model.getElementAttribute( 'styles' );
 47+ levels = levels.slice( 0, styles.length );
 48+ if ( styles[styles.length - 1] === 'number' ) {
 49+ if ( !levels[styles.length - 1] ) {
 50+ levels[styles.length - 1] = 0;
 51+ }
 52+ this.children[i].setNumber( ++levels[styles.length - 1] );
 53+ }
 54+ }
 55+};
 56+
4257 /* Methods */
4358
4459 es.HtmlSerializer.prototype.document = function( node, rawFirstParagraph ) {
Index: trunk/extensions/VisualEditor/modules/es/bases/es.DocumentModelNode.js
@@ -75,7 +75,7 @@
7676 obj.children.push( this.children[i].getPlainObject() );
7777 }
7878 } else if ( this.getContentLength() ) {
79 - obj.content = es.DocumentModel.expandContentData( this.getContent() );
 79+ obj.content = es.DocumentModel.getExpandedContentData( this.getContent() );
8080 }
8181 return obj;
8282 };

Status & tagging log