r101865 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101864‎ | r101865 | r101866 >
Date:19:56, 3 November 2011
Author:foxtrott
Status:ok
Tags:
Comment:
changing param 'wikieditor' to 'editor'
Modified paths:
  • /trunk/extensions/SemanticForms/includes/forminputs/SF_TextAreaInput.php (modified) (history)
  • /trunk/extensions/SemanticForms/includes/forminputs/SF_TextAreaWithAutocompleteInput.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/forminputs/SF_TextAreaInput.php
@@ -38,7 +38,8 @@
3939 // Use a special ID for the free text field, for FCK's needs.
4040 $input_id = $input_name == 'free_text' ? 'free_text' : "input_$sfgFieldNum";
4141
42 - if ( array_key_exists( 'wikieditor', $other_args ) &&
 42+ if ( array_key_exists( 'editor', $other_args ) &&
 43+ $other_args['editor'] == 'wikieditor' &&
4344
4445 method_exists( $wgOut, 'getResourceLoader' ) &&
4546 in_array( 'jquery.wikiEditor', $wgOut->getResourceLoader()->getModuleNames() ) &&
@@ -170,9 +171,15 @@
171172 * Returns the HTML code to be included in the output page for this input.
172173 */
173174 public function getHtmlText() {
 175+
174176 return self::getHTML(
175 - $this->mCurrentValue, $this->mInputName, $this->mIsMandatory, $this->mIsDisabled, $this->mOtherArgs
 177+ $this->mCurrentValue,
 178+ $this->mInputName,
 179+ $this->mIsMandatory,
 180+ $this->mIsDisabled,
 181+ $this->mOtherArgs
176182 );
 183+
177184 }
178185
179186 }
Index: trunk/extensions/SemanticForms/includes/forminputs/SF_TextAreaWithAutocompleteInput.php
@@ -48,7 +48,8 @@
4949
5050 $input_id = 'input_' . $sfgFieldNum;
5151
52 - if ( array_key_exists( 'wikieditor', $other_args ) &&
 52+ if ( array_key_exists( 'editor', $other_args ) &&
 53+ $other_args['editor'] == 'wikieditor' &&
5354
5455 method_exists( $wgOut, 'getResourceLoader' ) &&
5556 in_array( 'jquery.wikiEditor', $wgOut->getResourceLoader()->getModuleNames() ) &&

Status & tagging log