r101846 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101845‎ | r101846 | r101847 >
Date:18:39, 3 November 2011
Author:kaldari
Status:ok
Tags:
Comment:
enabling canada form, updating for new stuff
Modified paths:
  • /trunk/extensions/DonationInterface/donationinterface.php (modified) (history)
  • /trunk/extensions/DonationInterface/gateway_common/us-states.i18n.php (modified) (history)
  • /trunk/extensions/DonationInterface/gateway_forms/TwoStepTwoColumnLetterCA.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/donationinterface.php
@@ -90,6 +90,7 @@
9191 $wgAutoloadClasses['Gateway_Form_TwoStepTwoColumn'] = $donationinterface_dir . 'gateway_forms/TwoStepTwoColumn.php';
9292 $wgAutoloadClasses['Gateway_Form_TwoStepTwoColumnLetter'] = $donationinterface_dir . 'gateway_forms/TwoStepTwoColumnLetter.php';
9393 $wgAutoloadClasses['Gateway_Form_TwoStepTwoColumnLetter3'] = $donationinterface_dir . 'gateway_forms/TwoStepTwoColumnLetter3.php';
 94+$wgAutoloadClasses['Gateway_Form_TwoStepTwoColumnLetterCA'] = $donationinterface_dir . 'gateway_forms/TwoStepTwoColumnLetterCA.php';
9495 $wgAutoloadClasses['Gateway_Form_RapidHtml'] = $donationinterface_dir . 'gateway_forms/RapidHtml.php';
9596
9697 // All these form classes are available, but not enabled by default.
Index: trunk/extensions/DonationInterface/gateway_forms/TwoStepTwoColumnLetterCA.php
@@ -148,7 +148,7 @@
149149 $form .= '</tr>';
150150 $form .= '<tr>';
151151 $form .= '<td class="label">' . Xml::label( wfMsg( 'donate_interface-donor-country' ), 'country' ) . '</td>';
152 - $form .= '<td>' . $this->generateCountryDropdown( 124 ) . '</td>'; // Canada default
 152+ $form .= '<td>' . $this->generateCountryDropdown( 'CA' ) . '</td>'; // Canada default
153153 $form .= '</tr>';
154154
155155 return $form;
@@ -174,7 +174,7 @@
175175 }
176176
177177 public function generateStateDropdown() {
178 - require_once( dirname( __FILE__ ) . '/../includes/provinceAbbreviations.inc' );
 178+ require_once( dirname( __FILE__ ) . '/includes/provinceAbbreviations.inc' );
179179
180180 $states = statesMenuXML();
181181
Index: trunk/extensions/DonationInterface/gateway_common/us-states.i18n.php
@@ -1,6 +1,6 @@
22 <?php
33 /**
4 - * Internationalization file for the Donation Interface - PayflowPro - extension
 4+ * Internationalization file for the Donation Interface extension - US state names and codes
55 *
66 * @file
77 * @ingroup Extensions
@@ -10,7 +10,7 @@
1111
1212 /** English */
1313 $messages['en'] = array(
14 - // Below two messages are in donate_interface.i18n.php.
 14+ // Below two messages are in interface.i18n.php.
1515 //'donate_interface-state-dropdown-YY' => 'Select a State',
1616 //'donate_interface-state-dropdown-XX' => 'Outside the U.S.',
1717 'donate_interface-state-dropdown-AK' => 'Alaska',

Follow-up revisions

RevisionCommit summaryAuthorDate
r101849MFT r101846awjrichards18:54, 3 November 2011

Status & tagging log