r101791 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101790‎ | r101791 | r101792 >
Date:06:44, 3 November 2011
Author:jhsoby
Status:resolved (Comments)
Tags:
Comment:
essage=Adding two more messages, from the hub on Meta. Will add the translations we have for them tomorrow.
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_common/interface.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_common/interface.i18n.php
@@ -31,6 +31,7 @@
3232 'donate_interface-medium-amount-value' => '75',
3333 'donate_interface-small-amount-value' => '30',
3434 'donate_interface-amount-error' => '**Please enter a valid amount**',
 35+ 'donate_interface-smallamount-error' => 'You must contribute at least $1',
3536 'donate_interface-processing-error' => 'There has been an error processing your request.
3637 No processors are available.',
3738
@@ -193,6 +194,7 @@
194195 <p>The code is <i>always</i> located <i>above</i> the embossed (raised) account number on the face of the card.
195196 In some instances, the code is located on the left side of the card, but is always above the account number.</p><br />',
196197 'donate_interface-question-comment' => 'Questions or comments? Contact: <a href="mailto:donate@wikimedia.org">donate@wikimedia.org</a>',
 198+ 'donate_interface-easydonate' => 'We are trying to make it easy for people in every country to donate. Please let us know how we could make it easier for you. Send your suggestions to: problemsdonating@wikimedia.org.'
197199 'donate_interface-donate-click' => 'Your credit card will be securely processed.',
198200 'donate_interface-otherways' => 'There are <a href="http://wikimediafoundation.org/wiki/Ways_to_Give/en">other ways to give, including PayPal, check, or mail</a>.',
199201 'donate_interface-otherways-alt' => 'There are <a href="http://wikimediafoundation.org/wiki/Ways_to_Give/en">other ways to give</a>, including by check.',

Follow-up revisions

RevisionCommit summaryAuthorDate
r102064Localisation updates for core and extension messages from translatewiki.netraymond22:41, 4 November 2011

Comments

#Comment by Awjrichards (talk | contribs)   17:18, 3 November 2011
+        'donate_interface-smallamount-error' => 'You must contribute at least $1',

Did you mean this literally to mean one dollar or did you mean $1 to be a message parameter? If it's the former, this will not always behave as you might expect as '$1' is reserved as a message parameter (http://www.mediawiki.org/wiki/Localisation#Message_parameters) - also "one dollar" is a US-only thing (or I guess anywhere else $$ are used).

#Comment by Jsoby (talk | contribs)   19:47, 3 November 2011

No, it is a message parameter. I'll point that out in a qqq message.

#Comment by Awjrichards (talk | contribs)   23:02, 3 November 2011

Perfect. That will make Siebrand happy :)

From earlier today in #wmfstaff:

siebrand: awjr: donation_interface-smallamount-error is missing documentation, and it has a parameter. Please add, or kick whomever missed that.
#Comment by Pgehres (WMF) (talk | contribs)   19:19, 6 November 2011

Fixed by Raymond in r102064.

Status & tagging log