r101781 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101780‎ | r101781 | r101782 >
Date:02:43, 3 November 2011
Author:kaldari
Status:ok
Tags:
Comment:
follow-up to r101764 and r101576, fixing bogus call to $data
Modified paths:
  • /trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect_resultswitcher.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect_resultswitcher.body.php
@@ -103,17 +103,21 @@
104104 */
105105 function getDeclinedResultPage() {
106106 global $wgOut;
 107+
 108+ $displayData = $this->adapter->getDisplayData();
107109 $failpage = $this->adapter->getGlobal( 'FailPage' );
108110
109111 if ( $failpage ) {
110 - $wgOut->redirect( $failpage . "/" . $data['language'] );
 112+ $wgOut->redirect( $failpage . "/" . $displayData['language'] );
111113 } else {
112114 // general decline message
113115 $declinedDefault = wfMsg( 'php-response-declined' );
114116
115 - $displayData = $this->adapter->getDisplayData();
 117+ // The page we're going to send them back to.
 118+ // TODO: figure out something better so we aren't expanding the URL after every attempt.
116119 $referrer = $displayData['referrer'];
117120
 121+ // Tack on some data so that we can pre-populate the fields
118122 $queryArray = array (
119123 'fname' => $displayData['fname'],
120124 'lname' => $displayData['lname'],
@@ -129,7 +133,6 @@
130134 'error' => $declinedDefault,
131135 );
132136
133 - // TODO: figure out something better so we aren't expanding the URL after every attempt.
134137 $returnto = wfAppendQuery( htmlspecialchars_decode( $referrer ), $queryArray );
135138
136139 // Return the referrer URL with the data included in the query string

Follow-up revisions

RevisionCommit summaryAuthorDate
r101847MFT r101778, r101781, r101786, r101787, r101788, r101789awjrichards18:44, 3 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101576begining to handle transaction errors for globalcollect - this might be all w...kaldari02:22, 2 November 2011
r101764follow-up to r101576 to address comments. Next I will be experimenting with p...kaldari00:34, 3 November 2011

Status & tagging log