r101756 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101755‎ | r101756 | r101757 >
Date:00:13, 3 November 2011
Author:brion
Status:ok
Tags:
Comment:
* (bug 31870) Fix regression in AbuseFilter: pass/fail checkmark images for syntax checks work again

Was broken by r81905 consolidating background-repeat and background-position into a single background rule, which implied a 'background-image: none' overriding the background-image values set by other rules.
Restored them & added a comment so the next person won't do the same.

Also moved the image files to match the reorg of the css in r95572, which would have broken these images if r81905 hadn't done it first. ;)
Modified paths:
  • /trunk/extensions/AbuseFilter/modules/ext.abuseFilter.css (modified) (history)
  • /trunk/extensions/AbuseFilter/modules/red_x.png (added) (history)
  • /trunk/extensions/AbuseFilter/modules/yes_check.png (added) (history)
  • /trunk/extensions/AbuseFilter/red_x.png (deleted) (history)
  • /trunk/extensions/AbuseFilter/yes_check.png (deleted) (history)

Diff [purge]

Index: trunk/extensions/AbuseFilter/yes_check.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/AbuseFilter/red_x.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/AbuseFilter/modules/yes_check.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/extensions/AbuseFilter/modules/yes_check.png
___________________________________________________________________
Added: svn:mime-type
11 + image/png
Index: trunk/extensions/AbuseFilter/modules/red_x.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/extensions/AbuseFilter/modules/red_x.png
___________________________________________________________________
Added: svn:mime-type
22 + image/png
Index: trunk/extensions/AbuseFilter/modules/ext.abuseFilter.css
@@ -65,8 +65,10 @@
6666 #mw-abusefilter-syntaxresult,
6767 li.mw-abusefilter-changeslist-nomatch,
6868 li.mw-abusefilter-changeslist-match {
69 - background: no-repeat left center;
 69+ /* Do not consolidate these into a "background:" rule; it will override the background-image: settings in above rulesets */
 70+ background-repeat: no-repeat;
7071 padding-left: 25px;
 72+ background-position: left center;
7173 }
7274
7375 table.mw-abusefilter-diff {

Follow-up revisions

RevisionCommit summaryAuthorDate
r101758MFT r101756 -- bug 31870: fix Special:Abusefilter pass/fail icons broken by r...brion00:18, 3 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81905while to foreach...reedy17:25, 10 February 2011
r95572Adds ResourceLoader support to AbuseFilter...johnduhart20:12, 26 August 2011

Status & tagging log