r101674 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r101673‎ | r101674 | r101675 >
Date:20:31, 2 November 2011
Author:yaron
Status:deferred (Comments)
Tags:
Comment:
Follow-up to r101580 - added decodeCharReferences() call from patch
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_ParserFunctions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_ParserFunctions.php
——@@ -181,7 +181,7 @@
182182 } elseif ( $param_name == 'query string' ) {
183183 $inQueryStr = $value;
184184 } elseif ( $param_name == 'title' ) {
185 - $inTitle = $value;
 185+ $inTitle = Sanitizer::decodeCharReferences( $value );
186186 } elseif ( $param_name == 'target' ) {
187187 $inTargetName = $value;
188188 } elseif ( $param_name == null && $value == 'popup'

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101580Added handling for new 'title=' parameter for #formlink, based on a patch fro...yaron03:13, 2 November 2011

Comments

#Comment by Nikerabbit (talk | contribs)   07:21, 3 November 2011

Don't you need to do the same for $inLinkStr? I guess this is meant to avoid showing entitites as-is in the output.