r101629 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r101628‎ | r101629 | r101630 >
Date:15:15, 2 November 2011
Author:johnduhart
Status:resolved (Comments)
Tags:
Comment:
Followup r100305, don't try to do a batch query for an empty result (which would cause bug 32134)
Modified paths:
  • /trunk/phase3/includes/actions/HistoryAction.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/actions/HistoryAction.php
——@@ -385,6 +385,11 @@
386386 }
387387
388388 function doBatchLookups() {
 389+ # No results? Nothing to batch
 390+ if ( !$this->mResult->numRows() ) {
 391+ return;
 392+ }
 393+
389394 # Do a link batch query
390395 $this->mResult->seek( 0 );
391396 $batch = new LinkBatch();

Follow-up revisions

RevisionCommit summaryAuthorDate
r101640FU r101629, made Pager only call doBatchLookups() if there are rowsaaron17:33, 2 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100305* Added a proper Pager::doBatchLookups() function...aaron00:43, 20 October 2011

Comments

#Comment by Aaron Schulz (talk | contribs)   17:26, 2 November 2011

Pager should be refactored to only call doBatchLookups() if there are rows.

#Comment by Aaron Schulz (talk | contribs)   17:33, 2 November 2011

Done.

Status & tagging log