r101522 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101521‎ | r101522 | r101523 >
Date:20:25, 1 November 2011
Author:brion
Status:resolved (Comments)
Tags:
Comment:
Modified paths:
  • /branches/REL1_17/extensions/Cite/citeParserTests.txt (modified) (history)
  • /branches/REL1_17/phase3/includes/DefaultSettings.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/extensions/Cite/citeParserTests.txt
@@ -353,3 +353,19 @@
354354 <ol class="references"><li id="cite_note-0"><a href="#cite_ref-0">↑</a> Proceeds of Rockology, vol. XXI</li></ol>
355355
356356 !! end
 357+
 358+
 359+!! test
 360+Bug 31374 regression check: nested strip items
 361+!! input
 362+{{#tag:ref|note<ref>reference</ref>|group=Note}}
 363+<references group=Note />
 364+<references />
 365+!! result
 366+<p><sup id="cite_ref-1" class="reference"><a href="#cite_note-1">[Note 1]</a></sup>
 367+</p>
 368+<ol class="references"><li id="cite_note-1"><a href="#cite_ref-1">↑</a> note<sup id="cite_ref-0" class="reference"><a href="#cite_note-0">[1]</a></sup></li></ol>
 369+<ol class="references"><li id="cite_note-0"><a href="#cite_ref-0">↑</a> reference</li></ol>
 370+
 371+!! end
 372+
Index: branches/REL1_17/phase3/includes/DefaultSettings.php
@@ -2928,11 +2928,6 @@
29292929 $wgMinimalPasswordLength = 1;
29302930
29312931 /**
2932 - * Enabes or disables JavaScript-based suggestions of password strength
2933 - */
2934 -$wgLivePasswordStrengthChecks = false;
2935 -
2936 -/**
29372932 * Maximum number of Unicode characters in signature
29382933 */
29392934 $wgMaxSigChars = 255;

Follow-up revisions

RevisionCommit summaryAuthorDate
r105321Followup r101522, revert seemingly unrelated changedemon18:13, 6 December 2011
r106012Bug 31374: regression test made by Brion...hashar11:16, 13 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101520Bug 32125: remove stray $wgLivePasswordStrengthChecks leftover from a reverte...brion20:17, 1 November 2011
r101521MFT r101520 - bug 32125brion20:23, 1 November 2011

Comments

#Comment by Reach Out to the Truth (talk | contribs)   20:37, 1 November 2011

And also a Cite parser test?

#Comment by Hashar (talk | contribs)   11:17, 13 December 2011

Cite test removed by r105321 and added back with r106012

Status & tagging log