r101496 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101495‎ | r101496 | r101497 >
Date:16:29, 1 November 2011
Author:mah
Status:reverted (Comments)
Tags:
Comment:
followup 101492 — make it actually work.
Modified paths:
  • /trunk/phase3/includes/LocalisationCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LocalisationCache.php
@@ -851,7 +851,9 @@
852852
853853 public function get( $code, $key ) {
854854 $k = wfMemcKey( 'l10n', $code, 'k', $key );
855 - return $this->cache->get( $k );
 855+ $r = $this->cache->get( $k );
 856+ if ( $r === false ) return null;
 857+ return $r;
856858 }
857859
858860 public function startWrite( $code ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r101500Revert r101492, broken, see CR. Also revert followup r101496.catrope16:51, 1 November 2011
r101511follow up r101496 — ^demon's comments re stylemah18:49, 1 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101492Apply Vitaliy Filippov's patch from Bug #29283 with some small style modsmah16:10, 1 November 2011

Comments

#Comment by 😂 (talk | contribs)   16:49, 1 November 2011

A ternary would be nice on the return here since we don't like if's without braces :)

Status & tagging log