r101490 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101489‎ | r101490 | r101491 >
Date:16:07, 1 November 2011
Author:mah
Status:resolved (Comments)
Tags:
Comment:
Style fixups
Modified paths:
  • /trunk/phase3/includes/LocalisationCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LocalisationCache.php
@@ -190,12 +190,12 @@
191191 public function isMergeableKey( $key ) {
192192 if ( !isset( $this->mergeableKeys ) ) {
193193 $this->mergeableKeys = array_flip( array_merge(
194 - self::$mergeableMapKeys,
195 - self::$mergeableListKeys,
196 - self::$mergeableAliasListKeys,
197 - self::$optionalMergeKeys,
198 - self::$magicWordKeys
199 - ) );
 194+ self::$mergeableMapKeys,
 195+ self::$mergeableListKeys,
 196+ self::$mergeableAliasListKeys,
 197+ self::$optionalMergeKeys,
 198+ self::$magicWordKeys
 199+ ) );
200200 }
201201 return isset( $this->mergeableKeys[$key] );
202202 }
@@ -231,9 +231,8 @@
232232 * @return null
233233 */
234234 public function getSubitem( $code, $key, $subkey ) {
235 - if ( !isset( $this->loadedSubitems[$code][$key][$subkey] )
236 - && !isset( $this->loadedItems[$code][$key] ) )
237 - {
 235+ if ( !isset( $this->loadedSubitems[$code][$key][$subkey] ) &&
 236+ !isset( $this->loadedItems[$code][$key] ) ) {
238237 wfProfileIn( __METHOD__.'-load' );
239238 $this->loadSubitem( $code, $key, $subkey );
240239 wfProfileOut( __METHOD__.'-load' );
@@ -324,9 +323,8 @@
325324 }
326325
327326 // Check to see if initLanguage() loaded it for us
328 - if ( isset( $this->loadedItems[$code][$key] )
329 - || isset( $this->loadedSubitems[$code][$key][$subkey] ) )
330 - {
 327+ if ( isset( $this->loadedItems[$code][$key] ) ||
 328+ isset( $this->loadedSubitems[$code][$key][$subkey] ) ) {
331329 return;
332330 }
333331
@@ -507,7 +505,7 @@
508506 $oldSynonyms = array_slice( $fallbackInfo, 1 );
509507 $newSynonyms = array_slice( $value[$magicName], 1 );
510508 $synonyms = array_values( array_unique( array_merge(
511 - $newSynonyms, $oldSynonyms ) ) );
 509+ $newSynonyms, $oldSynonyms ) ) );
512510 $value[$magicName] = array_merge( array( $fallbackInfo[0] ), $synonyms );
513511 }
514512 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r101804followup r101490, remove extra tabs after talking to Nikerabbit.mah13:57, 3 November 2011

Comments

#Comment by Nikerabbit (talk | contribs)   07:39, 2 November 2011

I don't resonate with these changes.

Status & tagging log