r101399 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r101398‎ | r101399 | r101400 >
Date:20:08, 31 October 2011
Author:khorn
Status:ok (Comments)
Tags:
Comment:
Redefines the Gateway's idea of what it means to be posted, so we can display the correct stage of the form on the outside (and not do things like validate on the first load, if we're being redirected in a post-y sort of way).
r100459
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_common/gateway.adapter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_common/gateway.adapter.php
——@@ -177,7 +177,8 @@
178178 $this->postdata = $this->dataObj->getData();
179179 //TODO: Fix this a bit.
180180
181 - $this->posted = $wgRequest->wasPosted();
 181+ $this->posted = ( $wgRequest->wasPosted() && ( !is_null( $wgRequest->getVal( 'numAttempt', null ) ) ) );
 182+
182183 $this->setPostDefaults( $postDefaults );
183184 $this->defineTransactions();
184185 $this->defineVarMap();

Follow-up revisions

RevisionCommit summaryAuthorDate
r101401MFT r101399awjrichards20:12, 31 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100459Removed check for payment_method == processed. payment_method has been reallo...jpostlethwaite21:52, 21 October 2011

Comments

#Comment by 😂 (talk | contribs)   20:08, 31 October 2011

Isn't null the default second parameter for getVal() anyway?

#Comment by Platonides (talk | contribs)   20:15, 31 October 2011

Seems good to show it explicitely here, anyway.

Status & tagging log