r101347 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r101346‎ | r101347 | r101348 >
Date:10:16, 31 October 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
[RL2] Fix bug where shared gadget preferences weren't saved because 'default' was set to an empty array. This raises the question of whether we should honor the 'default' property on remote gadgets
Modified paths:
  • /branches/RL2/extensions/Gadgets/Gadgets.hooks.php (modified) (history)

Diff [purge]

Index: branches/RL2/extensions/Gadgets/Gadgets.hooks.php
——@@ -310,7 +310,7 @@
311311 'section' => 'gadgetsshared',
312312 'label' => '&#160;',
313313 'prefix' => 'gadget-',
314 - 'default' => array(),
 314+ //'default' => array(), // TODO: should we honor 'default':true remotely or not?
315315 'cssclass' => 'mw-gadgetsshared-item-unloaded',
316316 );
317317 return true;

Follow-up revisions

RevisionCommit summaryAuthorDate
r102781[RL2] Address the todo in r101347: per an IRC discussion with Krinkle, we don...catrope14:04, 11 November 2011

Comments

#Comment by Krinkle (talk | contribs)   00:11, 11 November 2011

Per IRC convo: 'enabledByDefault' should only apply to the local wiki.

  • Wiki A has a gadget that is shared and enabled by default
  • Wiki B has Wiki A as repository. On Wiki B the gadget is not loaded by default.

Status & tagging log