r101312 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101311‎ | r101312 | r101313 >
Date:20:49, 30 October 2011
Author:aaron
Status:ok
Tags:
Comment:
Renamed getRevisionTags -> getChangeTags
Modified paths:
  • /trunk/extensions/FlaggedRevs/presentation/specialpages/reports/ProblemChanges_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/presentation/specialpages/reports/ProblemChanges_body.php
@@ -108,7 +108,7 @@
109109 }
110110 }
111111
112 - // set pager parameters from $par, return pager limit
 112+ // set pager parameters from $par, return pager limit
113113 protected function parseParams( $par ) {
114114 $bits = preg_split( '/\s*,\s*/', trim( $par ) );
115115 $limit = false;
@@ -202,7 +202,7 @@
203203 $quality = " <b>[{$quality}]</b>";
204204 }
205205 # What are the tags?
206 - $dbTags = self::getRevisionTags( $title->getArticleID(), $row->stable );
 206+ $dbTags = self::getChangeTags( $title->getArticleID(), $row->stable );
207207 if ( $dbTags ) {
208208 $tags = htmlspecialchars( implode( ', ', $dbTags ) );
209209 $tags = ' <b>' . wfMsgHtml( 'parentheses', $tags ) . '</b>';
@@ -258,13 +258,14 @@
259259 * @param integer $revId, rev ID
260260 * @return Array
261261 */
262 - protected static function getRevisionTags( $pageId, $revId ) {
 262+ protected static function getChangeTags( $pageId, $revId ) {
263263 $tags = array();
264264 $dbr = wfGetDB( DB_SLAVE );
265265 $res = $dbr->select(
266266 array( 'revision', 'change_tag' ),
267267 'DISTINCT(ct_tag)', // unique tags
268 - array( 'rev_page' => $pageId, 'rev_id > ' . intval($revId),
 268+ array( 'rev_page' => $pageId,
 269+ 'rev_id > ' . intval( $revId ),
269270 'rev_id = ct_rev_id' ),
270271 __METHOD__
271272 );

Status & tagging log