r101283 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r101282‎ | r101283 | r101284 >
Date:21:13, 29 October 2011
Author:platonides
Status:deferred
Tags:
Comment:
Revert r87211 as r86072 which it was mimicking was also reverted in r96887.
Now it passes its tests again.
I'm not reverting r87214 although it seems it may be useless now.
Modified paths:
  • /trunk/extensions/NativePreprocessor/preprocesstoobj.c (modified) (history)

Diff [purge]

Index: trunk/extensions/NativePreprocessor/preprocesstoobj.c
——@@ -573,7 +573,7 @@
574574 if ( count >= rulemin ) {
575575 // Add it to the stack
576576 addNodeWithTags( found, count );
577 - parentNode->flags = (i == 0 || text[i-1] == '\n') /* lineStart boolean */;
 577+ parentNode->flags = (i > 0 && text[i-1] == '\n') /* lineStart boolean */;
578578 /* close char does not need to be stored per Known rules */
579579 parentNode->count = count;
580580 parentNode->argIndex = 0;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86072Followup to r86064 (List with double line-breaks inside tables). Also contain...diebuche19:28, 14 April 2011
r87211Update to incorporate the Preprocessor change of r86072 of what is a lineStartplatonides19:39, 1 May 2011
r87214Follow up r87211, update the unserializeNode() and fix flag resetting which w...platonides20:35, 1 May 2011
r96887Reverted r86072, r86419 per CR. Lots of conflicts resolved here. Removes line...aaron19:16, 12 September 2011

Status & tagging log