r101282 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101281‎ | r101282 | r101283 >
Date:21:12, 29 October 2011
Author:mkroetzsch
Status:ok
Tags:
Comment:
use appropriate display methods for wiki page values
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_Factbox.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/SMW_Factbox.php
@@ -69,9 +69,9 @@
7070 } elseif ( $propertyDi->isUserDefined() ) { // user defined property
7171 $propertyDv->setCaption( preg_replace( '/[ ]/u', ' ', $propertyDv->getWikiValue(), 2 ) );
7272 /// NOTE: the preg_replace is a slight hack to ensure that the left column does not get too narrow
73 - $text .= '<tr><td class="smwpropname">' . $propertyDv->getLongWikiText( true ) . '</td><td class="smwprops">';
 73+ $text .= '<tr><td class="smwpropname">' . $propertyDv->getShortWikiText( true ) . '</td><td class="smwprops">';
7474 } elseif ( $propertyDv->isVisible() ) { // predefined property
75 - $text .= '<tr><td class="smwspecname">' . $propertyDv->getLongWikiText( true ) . '</td><td class="smwspecs">';
 75+ $text .= '<tr><td class="smwspecname">' . $propertyDv->getShortWikiText( true ) . '</td><td class="smwspecs">';
7676 } else { // predefined, internal property
7777 continue;
7878 }
@@ -97,12 +97,6 @@
9898 $text .= '</table></div>';
9999 }
100100
101 - // Debugging: show all child objects
102 - // (does not play too well with Records, hence disabled by default)
103 -// foreach ( $semdata->getAllChildren() as $childSemanticData ) {
104 -// $text .= SMWFactbox::getFactboxText( $childSemanticData, $showfactbox );
105 -// }
106 -
107101 wfProfileOut( 'SMWFactbox::printFactbox (SMW)' );
108102 return $text;
109103 }

Status & tagging log