r101272 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101271‎ | r101272 | r101273 >
Date:15:37, 29 October 2011
Author:mkroetzsch
Status:ok
Tags:
Comment:
removed some deprecated functions
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_WikiPage.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/maintenance/SMW_conceptCache.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/maintenance/SMW_conceptCache.php
@@ -128,8 +128,6 @@
129129 $select_old = isset( $options['old'] ) ? intval( $options['old'] ) : false;
130130
131131 if ( isset( $options['concept'] ) ) { // single concept mode
132 - // $concept = SMWDataValueFactory::newTypeIDValue( '_wpg' );
133 - // $concept->setValues( 'African_countries', SMW_NS_CONCEPT );
134132 global $wgContLang;
135133 $concept = Title::newFromText( $wgContLang->getNsText( SMW_NS_CONCEPT ) . ':' . $options['concept'] );
136134 if ( $concept !== null ) {
Index: trunk/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_WikiPage.php
@@ -347,7 +347,7 @@
348348 /**
349349 * Find the sortkey for this object.
350350 *
351 - * @deprecated Use SMWStore::getWikiPageSortKey().
 351+ * @deprecated Use SMWStore::getWikiPageSortKey(). Will vanish before SMW 1.7
352352 *
353353 * @return string sortkey
354354 */
@@ -356,24 +356,6 @@
357357 }
358358
359359 /**
360 - * Init this data value object based on a given Title object.
361 - * @deprecated Use setDataItem(); it's easy to create an SMWDIWikiPage from a Title, will vanish before SMW 1.7
362 - */
363 - public function setTitle( $title ) {
364 - $diWikiPage = SMWDIWikiPage::newFromTitle( $title );
365 - $this->setDataItem( $diWikiPage );
366 - $this->m_title = $title; // optional, just for efficiency
367 - }
368 -
369 - /**
370 - * @deprecated Use setDataItem()
371 - */
372 - public function setValues( $dbkey, $namespace, $id = false, $interwiki = '' ) {
373 - $dataItem = new SMWDIWikiPage( $dbkey, $namespace, $interwiki );
374 - $this->setDataItem( $dataItem);
375 - }
376 -
377 - /**
378360 * Static function for creating a new wikipage object from
379361 * data as it is typically stored internally. In particular,
380362 * the title string is supposed to be in DB key form.

Status & tagging log