r101271 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101270‎ | r101271 | r101272 >
Date:15:32, 29 October 2011
Author:mkroetzsch
Status:ok
Tags:
Comment:
distinguish generated (internal) subobject names by an initial _
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_Record.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_Record.php
@@ -39,7 +39,7 @@
4040 } elseif ( is_null( $this->m_contextPage ) ) {
4141 $semanticData = SMWContainerSemanticData::makeAnonymousContainer();
4242 } else {
43 - $subobjectName = hash( 'md4', $value, false); // md4 is probably fastest of PHP's hashes
 43+ $subobjectName = '_' . hash( 'md4', $value, false); // md4 is probably fastest of PHP's hashes
4444 $subject = new SMWDIWikiPage( $this->m_contextPage->getDBkey(),
4545 $this->m_contextPage->getNamespace(), $this->m_contextPage->getInterwiki(),
4646 $subobjectName );

Status & tagging log