r101247 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r101246‎ | r101247 | r101248 >
Date:09:53, 29 October 2011
Author:aaron
Status:ok (Comments)
Tags:
Comment:
Updated rc_type documentation
Modified paths:
  • /trunk/phase3/includes/Defines.php (modified) (history)
  • /trunk/phase3/maintenance/tables.sql (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tables.sql
——@@ -1016,6 +1016,7 @@
10171017 -- default view.
10181018 rc_bot tinyint unsigned NOT NULL default 0,
10191019
 1020+ -- Set if this change corresponds to a page creation
10201021 rc_new tinyint unsigned NOT NULL default 0,
10211022
10221023 -- Key to page_id (was cur_id prior to 1.5).
——@@ -1029,8 +1030,10 @@
10301031 -- rev_id of the prior revision, for generating diff links.
10311032 rc_last_oldid int unsigned NOT NULL default 0,
10321033
 1034+ -- The type of change entry (RC_EDIT,RC_NEW,RC_LOG)
 1035+ rc_type tinyint unsigned NOT NULL default 0,
 1036+
10331037 -- These may no longer be used, with the new move log.
1034 - rc_type tinyint unsigned NOT NULL default 0,
10351038 rc_moved_to_ns tinyint unsigned NOT NULL default 0,
10361039 rc_moved_to_title varchar(255) binary NOT NULL default '',
10371040
Index: trunk/phase3/includes/Defines.php
——@@ -149,13 +149,12 @@
150150
151151 /**@{
152152 * RecentChange type identifiers
153 - * This may be obsolete; log items are now used for moves?
154153 */
155154 define( 'RC_EDIT', 0);
156155 define( 'RC_NEW', 1);
157 -define( 'RC_MOVE', 2);
 156+define( 'RC_MOVE', 2); // obsolete
158157 define( 'RC_LOG', 3);
159 -define( 'RC_MOVE_OVER_REDIRECT', 4);
 158+define( 'RC_MOVE_OVER_REDIRECT', 4); // obsolete
160159 /**@}*/
161160
162161 /**@{

Comments

#Comment by Nikerabbit (talk | contribs)   11:41, 29 October 2011

Should we get rid of the extra columns in rc table? It's unlikely that there would be any old style log entries there.

#Comment by Aaron Schulz (talk | contribs)   20:47, 29 October 2011

Well some wikis may be running super old versions, which might have RC item formatting problems if we just wipe the columns. I guess we can: (a) Migrate them and kill the columns (b) Assume that nobody is using them and kill them anyway

At some point they should go. Also, it might be nice to have a rc_type,rc_namespace,rc_timestamp index replace the rc_new,rc_namespace,rc_timestamp index (more general and no larger).

Status & tagging log