r101241 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101240‎ | r101241 | r101242 >
Date:01:49, 29 October 2011
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
Die @private
Modified paths:
  • /trunk/phase3/includes/LinksUpdate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LinksUpdate.php
@@ -329,7 +329,7 @@
330330
331331 /**
332332 * Update a table by doing a delete query then an insert query
333 - * @private
 333+ *
334334 */
335335 function incrTableUpdate( $table, $prefix, $deletions, $insertions ) {
336336 if ( $table == 'page_props' ) {
@@ -376,7 +376,7 @@
377377 /**
378378 * Get an array of pagelinks insertions for passing to the DB
379379 * Skips the titles specified by the 2-D array $existing
380 - * @private
 380+ *
381381 */
382382 function getLinkInsertions( $existing = array() ) {
383383 $arr = array();
@@ -397,7 +397,7 @@
398398
399399 /**
400400 * Get an array of template insertions. Like getLinkInsertions()
401 - * @private
 401+ *
402402 */
403403 function getTemplateInsertions( $existing = array() ) {
404404 $arr = array();
@@ -417,7 +417,6 @@
418418 /**
419419 * Get an array of image insertions
420420 * Skips the names specified in $existing
421 - * @private
422421 */
423422 function getImageInsertions( $existing = array() ) {
424423 $arr = array();
@@ -433,7 +432,6 @@
434433
435434 /**
436435 * Get an array of externallinks insertions. Skips the names specified in $existing
437 - * @private
438436 */
439437 function getExternalInsertions( $existing = array() ) {
440438 $arr = array();
@@ -453,7 +451,6 @@
454452 *
455453 * @param $existing Array mapping existing category names to sort keys. If both
456454 * match a link in $this, the link will be omitted from the output
457 - * @private
458455 */
459456 function getCategoryInsertions( $existing = array() ) {
460457 global $wgContLang, $wgCategoryCollation;
@@ -495,7 +492,7 @@
496493 * Get an array of interlanguage link insertions
497494 *
498495 * @param $existing Array mapping existing language codes to titles
499 - * @private
 496+ *
500497 */
501498 function getInterlangInsertions( $existing = array() ) {
502499 $diffs = array_diff_assoc( $this->mInterlangs, $existing );
@@ -529,7 +526,7 @@
530527 /**
531528 * Get an array of interwiki insertions for passing to the DB
532529 * Skips the titles specified by the 2-D array $existing
533 - * @private
 530+ *
534531 */
535532 function getInterwikiInsertions( $existing = array() ) {
536533 $arr = array();
@@ -549,7 +546,7 @@
550547 /**
551548 * Given an array of existing links, returns those links which are not in $this
552549 * and thus should be deleted.
553 - * @private
 550+ *
554551 */
555552 function getLinkDeletions( $existing ) {
556553 $del = array();
@@ -566,7 +563,7 @@
567564 /**
568565 * Given an array of existing templates, returns those templates which are not in $this
569566 * and thus should be deleted.
570 - * @private
 567+ *
571568 */
572569 function getTemplateDeletions( $existing ) {
573570 $del = array();
@@ -583,7 +580,7 @@
584581 /**
585582 * Given an array of existing images, returns those images which are not in $this
586583 * and thus should be deleted.
587 - * @private
 584+ *
588585 */
589586 function getImageDeletions( $existing ) {
590587 return array_diff_key( $existing, $this->mImages );
@@ -592,7 +589,7 @@
593590 /**
594591 * Given an array of existing external links, returns those links which are not
595592 * in $this and thus should be deleted.
596 - * @private
 593+ *
597594 */
598595 function getExternalDeletions( $existing ) {
599596 return array_diff_key( $existing, $this->mExternals );
@@ -601,7 +598,7 @@
602599 /**
603600 * Given an array of existing categories, returns those categories which are not in $this
604601 * and thus should be deleted.
605 - * @private
 602+ *
606603 */
607604 function getCategoryDeletions( $existing ) {
608605 return array_diff_assoc( $existing, $this->mCategories );
@@ -610,7 +607,7 @@
611608 /**
612609 * Given an array of existing interlanguage links, returns those links which are not
613610 * in $this and thus should be deleted.
614 - * @private
 611+ *
615612 */
616613 function getInterlangDeletions( $existing ) {
617614 return array_diff_assoc( $existing, $this->mInterlangs );
@@ -618,7 +615,7 @@
619616
620617 /**
621618 * Get array of properties which should be deleted.
622 - * @private
 619+ *
623620 */
624621 function getPropertyDeletions( $existing ) {
625622 return array_diff_assoc( $existing, $this->mProperties );
@@ -627,7 +624,7 @@
628625 /**
629626 * Given an array of existing interwiki links, returns those links which are not in $this
630627 * and thus should be deleted.
631 - * @private
 628+ *
632629 */
633630 function getInterwikiDeletions( $existing ) {
634631 $del = array();
@@ -643,7 +640,7 @@
644641
645642 /**
646643 * Get an array of existing links, as a 2-D array
647 - * @private
 644+ *
648645 */
649646 function getExistingLinks() {
650647 $res = $this->mDb->select( 'pagelinks', array( 'pl_namespace', 'pl_title' ),
@@ -660,7 +657,7 @@
661658
662659 /**
663660 * Get an array of existing templates, as a 2-D array
664 - * @private
 661+ *
665662 */
666663 function getExistingTemplates() {
667664 $res = $this->mDb->select( 'templatelinks', array( 'tl_namespace', 'tl_title' ),
@@ -677,7 +674,7 @@
678675
679676 /**
680677 * Get an array of existing images, image names in the keys
681 - * @private
 678+ *
682679 */
683680 function getExistingImages() {
684681 $res = $this->mDb->select( 'imagelinks', array( 'il_to' ),
@@ -691,7 +688,7 @@
692689
693690 /**
694691 * Get an array of existing external links, URLs in the keys
695 - * @private
 692+ *
696693 */
697694 function getExistingExternals() {
698695 $res = $this->mDb->select( 'externallinks', array( 'el_to' ),
@@ -705,7 +702,7 @@
706703
707704 /**
708705 * Get an array of existing categories, with the name in the key and sort key in the value.
709 - * @private
 706+ *
710707 */
711708 function getExistingCategories() {
712709 $res = $this->mDb->select( 'categorylinks', array( 'cl_to', 'cl_sortkey_prefix' ),
@@ -720,7 +717,7 @@
721718 /**
722719 * Get an array of existing interlanguage links, with the language code in the key and the
723720 * title in the value.
724 - * @private
 721+ *
725722 */
726723 function getExistingInterlangs() {
727724 $res = $this->mDb->select( 'langlinks', array( 'll_lang', 'll_title' ),
@@ -751,7 +748,7 @@
752749
753750 /**
754751 * Get an array of existing categories, with the name in the key and sort key in the value.
755 - * @private
 752+ *
756753 */
757754 function getExistingProperties() {
758755 $res = $this->mDb->select( 'page_props', array( 'pp_propname', 'pp_value' ),

Follow-up revisions

RevisionCommit summaryAuthorDate
r102097Followup r101241, after removing @private set private modifier as they are in...reedy14:20, 5 November 2011

Comments

#Comment by 😂 (talk | contribs)   00:45, 3 November 2011

Should they be private? Or public? Or protected? Removing the annotation without adding explicit visibility creates ambiguity.

Status & tagging log