r101120 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r101119‎ | r101120 | r101121 >
Date:06:04, 28 October 2011
Author:amire80
Status:ok (Comments)
Tags:
Comment:
Adding dirmark after changed bytes to prevent mixing with LTR usernames and summaries.
Modified paths:
  • /trunk/phase3/includes/ChangesList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ChangesList.php
——@@ -218,7 +218,7 @@
219219
220220 return Html::element( $tag,
221221 array( 'dir' => 'ltr', 'class' => $formattedSizeClass ),
222 - "($formattedSize)" );
 222+ "($formattedSize)" ) . $wgLang->getDirMark();
223223 }
224224
225225 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r101121Followup to r101120, replaced hardcoded parentheses with the 'parentheses' me...amire8008:04, 28 October 2011

Comments

#Comment by Santhosh.thottingal (talk | contribs)   06:29, 1 November 2011

Do we need to make 'dir' => 'ltr' dynamic like $this->isRTL() ? 'rtl ': 'ltr'

#Comment by Amire80 (talk | contribs)   06:58, 1 November 2011

No, at least not here, because it may affect a wiki in any language.

Status & tagging log