r101112 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101111‎ | r101112 | r101113 >
Date:02:06, 28 October 2011
Author:kaldari
Status:ok
Tags:
Comment:
adding missing params to AJAX and API for globalcollect
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_common/donation.api.php (modified) (history)
  • /trunk/extensions/DonationInterface/globalcollect_gateway/forms/js/webitects_2_3step.js (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/js/webitects_2_3step.js
@@ -159,6 +159,11 @@
160160 'payment_method': 'card',
161161 'language': language,
162162 'card_type': $( "input[name='cardtype']" ).val().toLowerCase(),
 163+ 'contribution_tracking_id': $( "input[name='contribution_tracking_id']" ).val(),
 164+ 'numAttempt': $( "input[name='numAttempt']" ).val(),
 165+ 'utm_source': $( "input[name='utm_source']" ).val(),
 166+ 'utm_campaign': $( "input[name='utm_campaign']" ).val(),
 167+ 'utm_medium': $( "input[name='utm_medium']" ).val(),
163168 'format': 'json'
164169 };
165170 $.ajax( {
Index: trunk/extensions/DonationInterface/gateway_common/donation.api.php
@@ -107,6 +107,11 @@
108108 'payment_submethod' => $this->defineParam( false ),
109109 'language' => $this->defineParam( false ),
110110 'order_id' => $this->defineParam( false ),
 111+ 'contribution_tracking_id' => $this->defineParam( false ),
 112+ 'numAttempt' => $this->defineParam( false ),
 113+ 'utm_source' => $this->defineParam( false ),
 114+ 'utm_campaign' => $this->defineParam( false ),
 115+ 'utm_medium' => $this->defineParam( false ),
111116 );
112117 }
113118
@@ -170,6 +175,11 @@
171176 'payment_submethod' => 'Payment submethod to use',
172177 'language' => 'Language code',
173178 'order_id' => 'Order ID (if a donation has already been started)',
 179+ 'contribution_tracking_id' => 'ID for contribution tracking table',
 180+ 'numAttempt' => 'How many attempts have been made to donate',
 181+ 'utm_source' => 'Tracking variable',
 182+ 'utm_campaign' => 'Tracking variable',
 183+ 'utm_medium' => 'Tracking variable',
174184 );
175185 }
176186

Follow-up revisions

RevisionCommit summaryAuthorDate
r101174MFT r101112, r101163awjrichards19:13, 28 October 2011

Status & tagging log