r101105 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101104‎ | r101105 | r101106 >
Date:00:57, 28 October 2011
Author:raindrift
Status:ok (Comments)
Tags:
Comment:
somehow missed the hooks in r100925
also, added message documentation for new msgs
Modified paths:
  • /trunk/extensions/UploadWizard/UploadWizard.i18n.php (modified) (history)
  • /trunk/extensions/UploadWizard/UploadWizardHooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/UploadWizardHooks.php
@@ -39,6 +39,7 @@
4040 'resources/jquery/jquery.autocomplete.js',
4141 'resources/jquery/jquery.spinner.js',
4242 'resources/jquery/jquery.removeCtrl.js',
 43+ 'resources/jquery/jquery.showThumbCtrl.js',
4344 'resources/jquery/jquery.pubsub.js',
4445
4546 // common utilities
@@ -108,6 +109,7 @@
109110 'resources/jquery/jquery.arrowSteps.css',
110111 'resources/jquery/jquery.mwCoolCats.css',
111112 'resources/jquery/jquery.removeCtrl.css',
 113+ 'resources/jquery/jquery.showThumbCtrl.css',
112114 ),
113115 'messages' => array(
114116 'uploadwizard',
@@ -174,6 +176,8 @@
175177 'mwe-upwiz-remove',
176178 'mwe-upwiz-remove-upload',
177179 'mwe-upwiz-remove-description',
 180+ 'mwe-upwiz-show-thumb',
 181+ 'mwe-upwiz-show-thumb-tip',
178182 'mwe-upwiz-upload',
179183 'mwe-upwiz-file-all-ok',
180184 'mwe-upwiz-file-some-failed',
Index: trunk/extensions/UploadWizard/UploadWizard.i18n.php
@@ -83,6 +83,8 @@
8484 'mwe-upwiz-failed' => 'Failed.',
8585 'mwe-upwiz-remove' => 'Remove',
8686 'mwe-upwiz-remove-upload' => 'Remove this file from the list of files to upload',
 87+ 'mwe-upwiz-show-thumb' => 'Show Thumbnail',
 88+ 'mwe-upwiz-show-thumb-tip' => 'Load a thumbnail image for this file',
8789 'mwe-upwiz-remove-description' => 'Remove this description',
8890 'mwe-upwiz-upload' => 'Upload',
8991 'mwe-upwiz-file-all-ok' => 'All uploads were successful!',
@@ -426,6 +428,8 @@
427429 'mwe-upwiz-transported' => '{{Identical|OK}}',
428430 'mwe-upwiz-stashed-upload' => '{{Identical|OK}}',
429431 'mwe-upwiz-remove' => '{{Identical|Remove}}',
 432+ 'mwe-upwiz-show-thumb' => 'Link text for the control that displays a thumbnail manually, when automatic client-side thumbs are disabled for performance',
 433+ 'mwe-upwiz-show-thumb-tip' => 'The tooltip for the mwe-upwiz-show-thumb link',
430434 'mwe-upwiz-upload' => '{{Identical|Upload}}',
431435 'mwe-upwiz-source-thirdparty-accept' => '{{Identical|OK}}',
432436 'mwe-upwiz-more-options' => "Text for a 'more options' toggle that opens more of a form so a user can make more detailed descriptions/add more properties for uploaded images.",

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100925new thumbnail behavior for thumbnailing with multi-file uploads. Multi-file ...raindrift01:02, 27 October 2011

Comments

#Comment by Siebrand (talk | contribs)   08:32, 28 October 2011
+	'mwe-upwiz-show-thumb' => 'Show Thumbnail',

We don't use Title Case

#Comment by Raindrift (talk | contribs)   19:01, 28 October 2011

Thanks! Fixed in r101171

Status & tagging log