r101099 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101098‎ | r101099 | r101100 >
Date:00:26, 28 October 2011
Author:khorn
Status:ok
Tags:
Comment:
Temporary fix so ContributionTracking stops leaking numbers in DonationData.
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_common/DonationData.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_common/DonationData.php
@@ -92,7 +92,13 @@
9393 $this->normalizeAndSanitize();
9494
9595 //TODO: test with _cache_ on.
96 - if ( !empty( $this->normalized ) && ( $this->getVal( 'numAttempt' ) == '0' && ((!$this->getVal( 'utm_source_id' ) == false ) || is_null($this->getVal( '_cache_' )) ) ) ) {
 96+// if ( !empty( $this->normalized ) &&
 97+// ( $this->getVal( 'numAttempt' ) == '0' &&
 98+// ((!$this->getVal( 'utm_source_id' ) == false ) ||
 99+// is_null($this->getVal( '_cache_' )) ) ) ) {
 100+// error_log('about to save contribution tracking from an initial populate: ' . $this->getVal('contribution_tracking_id'));
 101+
 102+ if (!$this->isSomething( 'contribution_tracking_id' )){
97103 $this->saveContributionTracking();
98104 }
99105 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r101102MFT r101056, r101071, r101072, r101099awjrichards00:49, 28 October 2011

Status & tagging log