r101054 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101053‎ | r101054 | r101055 >
Date:21:03, 27 October 2011
Author:platonides
Status:ok
Tags:
Comment:
thumb-handler.php uses different globals than everyone else.
Modified paths:
  • /trunk/tools/code-utils/check-vars.php (modified) (history)

Diff [purge]

Index: trunk/tools/code-utils/check-vars.php
@@ -943,6 +943,9 @@
944944 if ( $name == '$wgHooks' && $this->mClass == 'Installer' && $this->mFunction == 'includeExtensions' )
945945 return false;
946946
 947+ if ( basename( $this->mFilename ) == "thumb-handler.php" )
 948+ return substr( $name, 0, 9 ) == '$thgThumb';
 949+
947950 return ( ( substr( $name, 0, 3 ) == '$wg' ) || ( substr( $name, 0, 3 ) == '$eg' ) || in_array( $name, $specialGlobals ) ) && !in_array( $name, $nonGlobals );
948951 }
949952

Follow-up revisions

RevisionCommit summaryAuthorDate
r104251Update r101054 to r101077 rename.platonides18:51, 25 November 2011

Status & tagging log