r101019 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101018‎ | r101019 | r101020 >
Date:18:37, 27 October 2011
Author:aaron
Status:ok
Tags:
Comment:
Added default updateSkippedMessage() message
Modified paths:
  • /trunk/phase3/maintenance/Maintenance.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/Maintenance.php
@@ -1277,6 +1277,15 @@
12781278 }
12791279
12801280 /**
 1281+ * Message to show that the update was done already and was just skipped
 1282+ * @return String
 1283+ */
 1284+ protected function updateSkippedMessage() {
 1285+ $key = $this->getUpdateKey();
 1286+ return "Update '{$key}' already logged as completed.";
 1287+ }
 1288+
 1289+ /**
12811290 * Message to show the the update log was unable to log the completion of this update
12821291 * @return String
12831292 */
@@ -1297,10 +1306,4 @@
12981307 * @return String
12991308 */
13001309 abstract protected function getUpdateKey();
1301 -
1302 - /**
1303 - * Message to show that the update was done already and was just skipped
1304 - * @return String
1305 - */
1306 - abstract protected function updateSkippedMessage();
13071310 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r103033REL1_18 Partial manual merge of r94370, r94382, r96578, r101019 to bring Logg...reedy21:20, 14 November 2011

Status & tagging log