r100932 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r100931‎ | r100932 | r100933 >
Date:01:36, 27 October 2011
Author:aaron
Status:resolved (Comments)
Tags:
Comment:
Disabled "bad image" tests which made totally broken assumptions about how/when the bad_image_list message is loaded. This caused failures with r100883. More direct tests were added in r100915.
Modified paths:
  • /trunk/phase3/tests/parser/parserTests.txt (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/parser/parserTests.txt
——@@ -8522,6 +8522,8 @@
85238523 !! end
85248524
85258525 !! test
 8526+!! options
 8527+disabled
85268528 Bad images - basic functionality
85278529 !! input
85288530 [[File:Bad.jpg]]
——@@ -8529,6 +8531,8 @@
85308532 !! end
85318533
85328534 !! test
 8535+!! options
 8536+disabled
85338537 Bad images - bug 16039: text after bad image disappears
85348538 !! input
85358539 Foo bar

Follow-up revisions

RevisionCommit summaryAuthorDate
r104547restore parser tests names...hashar10:22, 29 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100883Fixed process cache for bad images when the list is emptyaaron21:48, 26 October 2011
r100915* Allow passing in a blacklist into wfIsBadImage()...aaron00:23, 27 October 2011

Comments

#Comment by Nikerabbit (talk | contribs)   07:00, 27 October 2011

So what is the plan? Just to leave these disabled forever?

Status & tagging log