r100848 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100847‎ | r100848 | r100849 >
Date:19:11, 26 October 2011
Author:petrb
Status:deferred (Comments)
Tags:
Comment:
several fixes including collision fix with gadgets
Modified paths:
  • /trunk/extensions/OnlineStatusBar/20px-Ledgreen.svg.png (deleted) (history)
  • /trunk/extensions/OnlineStatusBar/20px-Ledorange.svg.png (deleted) (history)
  • /trunk/extensions/OnlineStatusBar/20px-Nuvola_apps_krec.svg.png (deleted) (history)
  • /trunk/extensions/OnlineStatusBar/OnlineStatusBar.body.php (modified) (history)
  • /trunk/extensions/OnlineStatusBar/OnlineStatusBar.i18n.php (modified) (history)
  • /trunk/extensions/OnlineStatusBar/OnlineStatusBar.php (modified) (history)
  • /trunk/extensions/OnlineStatusBar/statusgreen.png (added) (history)
  • /trunk/extensions/OnlineStatusBar/statusorange.png (added) (history)
  • /trunk/extensions/OnlineStatusBar/statusred.png (added) (history)

Diff [purge]

Index: trunk/extensions/OnlineStatusBar/20px-Nuvola_apps_krec.svg.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/OnlineStatusBar/20px-Ledorange.svg.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/OnlineStatusBar/20px-Ledgreen.svg.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/OnlineStatusBar/OnlineStatusBar.body.php
@@ -79,7 +79,7 @@
8080 }
8181
8282 public static function IsValid( $id ) {
83 - global $wgOnlineStatusBarDefaultIpUsers;
 83+ global $wgOnlineStatusBarDefaultIpUsers, $wgOnlineStatusBarDefaultEnabled;
8484 // checks if anon
8585 if ( User::isIP( $id ) ) {
8686 return $wgOnlineStatusBarDefaultIpUsers;
@@ -90,7 +90,11 @@
9191 return false;
9292 }
9393 // do we track them
94 - if ( $user->getOption( "OnlineStatusBar_active" ) == true ) {
 94+ $value = $user->getOption( "OnlineStatusBar_active" );
 95+ if ( $value == null ) {
 96+ return $wgOnlineStatusBarDefaultEnabled;
 97+ }
 98+ if ( $value == true ) {
9599 return true;
96100 }
97101 return false;
Index: trunk/extensions/OnlineStatusBar/OnlineStatusBar.i18n.php
@@ -17,6 +17,6 @@
1818 'onlinestatusbar-line' => "$1 is now $2 $3",
1919 'onlinestatusbar-used' => 'Do you want to let others see if you are online?',
2020 'onlinestatusbar-status' => 'What is the default status you wish to use:',
21 - 'prefs-gadgets' => 'Gadgets',
 21+ 'prefs-onlinestatusbar' => 'Online status bar',
2222 'prefs-onlinestatus' => 'Online Status',
2323 );
Index: trunk/extensions/OnlineStatusBar/statusred.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/extensions/OnlineStatusBar/statusred.png
___________________________________________________________________
Added: svn:mime-type
2424 + image/png
Index: trunk/extensions/OnlineStatusBar/statusorange.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/extensions/OnlineStatusBar/statusorange.png
___________________________________________________________________
Added: svn:mime-type
2525 + image/png
Index: trunk/extensions/OnlineStatusBar/OnlineStatusBar.php
@@ -58,7 +58,7 @@
5959 $wgOnlineStatusBarDefaultOnline = "online";
6060 // default for offline
6161 $wgOnlineStatusBarDefaultOffline = "offline";
62 -// if new users have this feature enabled by default (experimental)
 62+// if users have this feature enabled by default
6363 $wgOnlineStatusBarDefaultEnabled = false;
6464 // how long to wait until user is considered as offline
6565 $wgOnlineStatusBar_LogoutTime = 3600;
@@ -111,8 +111,8 @@
112112 $wgHooks['GetPreferences'][] = 'wfOnlineStatusBar_PreferencesHook';
113113 function wfOnlineStatusBar_PreferencesHook( $user, &$preferences ) {
114114 global $wgOnlineStatusBarModes;
115 - $preferences['OnlineStatusBar_active'] = array( 'type' => 'toggle', 'label-message' => 'onlinestatusbar-used', 'section' => 'gadgets/onlinestatus' );
116 - $preferences['OnlineStatusBar_status'] = array( 'type' => 'radio', 'label-message' => 'onlinestatusbar-status', 'section' => 'gadgets/onlinestatus',
 115+ $preferences['OnlineStatusBar_active'] = array( 'type' => 'toggle', 'label-message' => 'onlinestatusbar-used', 'section' => 'onlinestatusbar/onlinestatus' );
 116+ $preferences['OnlineStatusBar_status'] = array( 'type' => 'radio', 'label-message' => 'onlinestatusbar-status', 'section' => 'onlinestatusbar/onlinestatus',
117117 'options' => array(
118118 $wgOnlineStatusBarModes['online'] => 'online',
119119 $wgOnlineStatusBarModes['busy'] => 'busy',
Index: trunk/extensions/OnlineStatusBar/statusgreen.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/extensions/OnlineStatusBar/statusgreen.png
___________________________________________________________________
Added: svn:mime-type
120120 + image/png

Follow-up revisions

RevisionCommit summaryAuthorDate
r100849fixed picture namespetrb19:14, 26 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100835user configuration...petrb18:30, 26 October 2011

Comments

#Comment by TheDJ (talk | contribs)   19:17, 26 October 2011

Conflict issue: r100848

Status & tagging log