r100751 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100750‎ | r100751 | r100752 >
Date:21:52, 25 October 2011
Author:jpostlethwaite
Status:resolved
Tags:fundraising 
Comment:
Added in issuer_id for real time bank transfer.
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_common/DonationData.php (modified) (history)
  • /trunk/extensions/DonationInterface/gateway_forms/Form.php (modified) (history)
  • /trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_forms/Form.php
@@ -364,6 +364,7 @@
365365 // payment_method is no longer set to: processed
366366 'payment_method' => isset( $this->form_data['payment_method'] ) ? $this->form_data['payment_method'] : '',
367367 'payment_submethod' => isset( $this->form_data['payment_submethod'] ) ? $this->form_data['payment_submethod'] : '',
 368+ 'issuer_id' => isset( $this->form_data['issuer_id'] ) ? $this->form_data['issuer_id'] : '',
368369 'token' => $this->form_data['token'],
369370 'order_id' => $this->form_data['order_id'],
370371 'i_order_id' => $this->form_data['i_order_id'],
Index: trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php
@@ -105,6 +105,7 @@
106106 ),
107107 'PAYMENT' => array(
108108 'PAYMENTPRODUCTID',
 109+ 'ISSUERID',
109110 'AMOUNT',
110111 'CURRENCYCODE',
111112 'LANGUAGECODE',
@@ -564,6 +565,8 @@
565566 //'card_num',
566567 'returnto',
567568 'payment_method',
 569+ 'payment_submethod',
 570+ 'issuer_id',
568571 'order_id', //This may or may not oughta-be-here...
569572 );
570573 }
Index: trunk/extensions/DonationInterface/gateway_common/DonationData.php
@@ -59,6 +59,7 @@
6060 'currency' => $wgRequest->getText( 'currency_code' ),
6161 'payment_method' => $wgRequest->getText( 'payment_method' ),
6262 'payment_submethod' => $wgRequest->getText( 'payment_submethod', null ), // Used by GlobalCollect for payment types
 63+ 'issuer_id' => $wgRequest->getText( 'issuer_id' ),
6364 'order_id' => $wgRequest->getText( 'order_id', null ), //as far as I know, this won't actually ever pull anything back.
6465 'i_order_id' => $wgRequest->getText( 'i_order_id', null ), //internal id for each contribution attempt
6566 'numAttempt' => $wgRequest->getVal( 'numAttempt', '0' ),
@@ -152,6 +153,7 @@
153154 'currency' => 'USD',
154155 'payment_method' => $wgRequest->getText( 'payment_method' ),
155156 'payment_submethod' => $wgRequest->getText( 'payment_submethod' ),
 157+ 'issuer_id' => $wgRequest->getText( 'issuer_id' ),
156158 'order_id' => '1234567890',
157159 'i_order_id' => '1234567890',
158160 'numAttempt' => 0,

Follow-up revisions

RevisionCommit summaryAuthorDate
r100753ISSUERID was not supposed to go in this array. See r100751.jpostlethwaite22:08, 25 October 2011

Status & tagging log