r100660 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r100659‎ | r100660 | r100661 >
Date:22:51, 24 October 2011
Author:khorn
Status:deferred (Comments)
Tags:
Comment:
Gateway-specific anything does not belong in the abstract parent class.
r100409
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_common/gateway.adapter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_common/gateway.adapter.php
——@@ -184,9 +184,9 @@
185185 $this->defineReturnValueMap();
186186
187187 //Don't bother setting the transaction type if it's not something.
188 - if ( $this->dataObj->isSomething( 'payment_method' ) ) {
189 - $this->currentTransaction('INSERT_ORDERWITHPAYMENT');
190 - }
 188+// if ( $this->dataObj->isSomething( 'payment_method' ) ) {
 189+// $this->currentTransaction('INSERT_ORDERWITHPAYMENT');
 190+// }
191191
192192 $this->displaydata = $this->postdata;
193193 $this->stageData();

Follow-up revisions

RevisionCommit summaryAuthorDate
r100866Removed commented code from gateway adapter, see r100660.jpostlethwaite20:42, 26 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100409Getting rid of BANK_TRANSFER. Adding $transaction_groups and $transaction_types.jpostlethwaite04:23, 21 October 2011

Comments

#Comment by Jpostlethwaite (talk | contribs)   21:01, 26 October 2011

We should know what to about this when we handle the transaction: DO_BANKVALIDATION

#Comment by Khorn (WMF) (talk | contribs)   03:59, 27 October 2011

That's still a GlobalCollect transaction. Anything gateway-specific belongs in the gateway it's specific to, and not in the abstract parent class. (And the answer there is do_transaction('DO_BANKVALIDATION') from the outside. :) )

#Comment by Jpostlethwaite (talk | contribs)   04:02, 27 October 2011

Right, I was just saying that we would know what to do because this is marked as deferred.

Status & tagging log