r100657 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100656‎ | r100657 | r100658 >
Date:22:33, 24 October 2011
Author:aaron
Status:resolved
Tags:
Comment:
Fixed merge mismatches in r100655
Modified paths:
  • /branches/wmf/1.18wmf1/includes/User.php (modified) (history)
  • /branches/wmf/1.18wmf1/includes/specials/SpecialMovepage.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/includes/User.php
@@ -2920,6 +2920,7 @@
29212921 * @return bool A block was spread
29222922 */
29232923 protected function spreadBlock() {
 2924+ global $wgRequest;
29242925 wfDebug( __METHOD__ . "()\n" );
29252926 $this->load();
29262927 if ( $this->mId == 0 ) {
@@ -2931,7 +2932,7 @@
29322933 return false;
29332934 }
29342935
2935 - return (bool)$userblock->doAutoblock( $this->getRequest()->getIP() );
 2936+ return (bool)$userblock->doAutoblock( $wgRequest->getIP() );
29362937 }
29372938
29382939 /**
Index: branches/wmf/1.18wmf1/includes/specials/SpecialMovepage.php
@@ -75,7 +75,7 @@
7676 $permErrors = $this->oldTitle->getUserPermissionsErrors( 'move', $wgUser );
7777 if( !empty( $permErrors ) ) {
7878 // Auto-block user's IP if the account was "hard" blocked
79 - $user->spreadAnyEditBlock();
 79+ $wgUser->spreadAnyEditBlock();
8080 $this->getOutput()->showPermissionsErrorPage( $permErrors );
8181 return;
8282 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r100658Fix r100657, just use wfGetIP()...sighaaron22:38, 24 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100655MFT r99323, r99349 - 'Only spread blocks on page edit/move attempts via sprea...aaron22:27, 24 October 2011

Status & tagging log