r100638 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100637‎ | r100638 | r100639 >
Date:19:20, 24 October 2011
Author:awjrichards
Status:ok (Comments)
Tags:fundraising 
Comment:
Removing unused global from RapidHtml->set_html_file_path
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_forms/RapidHtml.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_forms/RapidHtml.php
@@ -255,9 +255,6 @@
256256 * @param string $form_key The array key defining the whitelisted form path to fetch from $wg<gateway>AllowedHtmlForms
257257 */
258258 public function set_html_file_path( $form_key ) {
259 - //This ONE TIME, this is okay, because we actually want to compare to the default HTML form dir as well.
260 - global $wgDonationInterfaceHtmlFormDir;
261 -
262259 $g = $this->gateway;
263260 $gatewayFormDir = $g::getGlobal( 'HtmlFormDir' );
264261 $allowedForms = $g::getGlobal( 'AllowedHtmlForms' );

Comments

#Comment by 😂 (talk | contribs)   19:22, 24 October 2011

Just keeping in mind:

$g::getGlobal( 'HtmlFormDir' );

Will not work unless you're on 5.3+. Granted all the appservers are now running Lucid and are on 5.3.2, but something to keep in mind.

Status & tagging log