r100624 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100623‎ | r100624 | r100625 >
Date:17:27, 24 October 2011
Author:jpostlethwaite
Status:resolved (Comments)
Tags:fundraising 
Comment:
Added issuers for real time bank transfers. Added getGatewayMerchantId() for unit testing.
Modified paths:
  • /trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php
@@ -240,6 +240,17 @@
241241 'label' => 'Ideal',
242242 'group' => 'rtbt',
243243 'validation' => array( 'creditCard' => false, ),
 244+ 'issuerids' => array(
 245+ 771 => 'RegioBank',
 246+ 161 => 'Van Lanschot Bankiers',
 247+ 31 => 'ABN AMRO',
 248+ 761 => 'ASN Bank',
 249+ 21 => 'Rabobank',
 250+ 511 => 'Triodos Bank',
 251+ 721 => 'ING',
 252+ 751 => 'SNS Bank',
 253+ 91 => 'Friesland Bank',
 254+ )
244255 );
245256
246257 // eNETS
@@ -265,22 +276,32 @@
266277 'group' => 'rtbt',
267278 'validation' => array( 'creditCard' => false, ),
268279 'issuerids' => array(
269 - 824 => 'Bankhaus Spängler',
270 - 825 => 'Hypo Tirol Bank',
271 - 822 => 'NÖ HYPO',
272 - 823 => 'Voralberger HYPO',
273 - 828 => 'P.S.K.',
274 - 829 => 'Easy',
275 - 826 => 'Erste Bank und Sparkassen',
276 - 827 => 'BAWAG',
277 - 820 => 'Raifeissen',
278 - 821 => 'Volksbanken Gruppe',
279 - 831 => 'Sparda-Bank',
 280+ 824 => 'Bankhaus Spängler',
 281+ 825 => 'Hypo Tirol Bank',
 282+ 822 => 'NÖ HYPO',
 283+ 823 => 'Voralberger HYPO',
 284+ 828 => 'P.S.K.',
 285+ 829 => 'Easy',
 286+ 826 => 'Erste Bank und Sparkassen',
 287+ 827 => 'BAWAG',
 288+ 820 => 'Raifeissen',
 289+ 821 => 'Volksbanken Gruppe',
 290+ 831 => 'Sparda-Bank',
280291 )
281292 );
282293 }
283294
284295 /**
 296+ * Get the Global Collect Merchant Id
 297+ */
 298+ public function getGatewayMerchantId() {
 299+
 300+ global $wgGlobalCollectGatewayMerchantID;
 301+
 302+ return $wgGlobalCollectGatewayMerchantID;
 303+ }
 304+
 305+ /**
285306 * Get payment method meta
286307 *
287308 * @param string $payment_method Payment methods contain payment submethods
@@ -296,7 +317,7 @@
297318 throw new Exception( $message );
298319 }
299320 }
300 -
 321+
301322 /**
302323 * Get payment submethod meta
303324 *
@@ -535,7 +556,7 @@
536557 case 'rtbt_ideal':
537558 $this->postdata['payment_product'] = 809;
538559 $this->var_map['PAYMENTPRODUCTID'] = 'payment_product';
539 - //$this->var_map['ISSUERID'] = 'issuer';
 560+ $this->var_map['ISSUERID'] = 'issuer';
540561 break;
541562
542563 case 'rtbt_enets':

Follow-up revisions

RevisionCommit summaryAuthorDate
r100919Removes an unnecessary specific global-getting function in the adapter - chan...khorn00:36, 27 October 2011

Comments

#Comment by Khorn (WMF) (talk | contribs)   18:50, 27 October 2011

I already fixed this in r100919, but getGlobal already retrieves gateway globals in a publically accessible way.

Status & tagging log