r100619 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r100618‎ \| r100619 \| r100620 >
Date:	17:22, 24 October 2011
Author:	awjrichards
Status:	ok (Comments)
Tags:	fundraising
Comment:	Fixing CSS path for remaining old PHP forms from payflowpro
Modified paths:	/trunk/extensions/DonationInterface/gateway_forms/TwoColumnLetter.php (modified) (history) /trunk/extensions/DonationInterface/gateway_forms/TwoColumnLetter2.php (modified) (history) /trunk/extensions/DonationInterface/gateway_forms/TwoColumnLetter3.php (modified) (history) /trunk/extensions/DonationInterface/gateway_forms/TwoColumnLetter4.php (modified) (history) /trunk/extensions/DonationInterface/gateway_forms/TwoColumnLetter5.php (modified) (history) /trunk/extensions/DonationInterface/gateway_forms/TwoColumnLetter6.php (modified) (history) /trunk/extensions/DonationInterface/gateway_forms/TwoColumnLetter7.php (modified) (history) /trunk/extensions/DonationInterface/gateway_forms/TwoStepTwoColumnLetter2.php (modified) (history) /trunk/extensions/DonationInterface/gateway_forms/TwoStepTwoColumnLetterCA.php (modified) (history) /trunk/extensions/DonationInterface/gateway_forms/TwoStepTwoColumnPremiumUS.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_forms/TwoColumnLetter2.php
—	—	@@ -8,7 +8,7 @@
9	9
10	10	// set the path to css, before the parent constructor is called, checking to make sure some child class hasn't already set this
11	11	if ( !strlen( $this->getStylePath() ) ) {
12		~~- $this->setStylePath( $wgScriptPath . '/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoColumnLetter.css' );~~
	12	+ $this->setStylePath( $wgScriptPath . '/extensions/DonationInterface/gateway_forms/css/TwoColumnLetter.css' );
13	13	}
14	14
15	15	parent::__construct( $form_data, $form_errors, $gateway );
Index: trunk/extensions/DonationInterface/gateway_forms/TwoColumnLetter3.php
—	—	@@ -8,7 +8,7 @@
9	9
10	10	// set the path to css, before the parent constructor is called, checking to make sure some child class hasn't already set this
11	11	if ( !strlen( $this->getStylePath() ) ) {
12		~~- $this->setStylePath( $wgScriptPath . '/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoColumnLetter.css' );~~
	12	+ $this->setStylePath( $wgScriptPath . '/extensions/DonationInterface/gateway_forms/css/TwoColumnLetter.css' );
13	13	}
14	14
15	15	parent::__construct( $form_data, $form_errors, $gateway );
Index: trunk/extensions/DonationInterface/gateway_forms/TwoColumnLetter4.php
—	—	@@ -8,7 +8,7 @@
9	9
10	10	// set the path to css, before the parent constructor is called, checking to make sure some child class hasn't already set this
11	11	if ( !strlen( $this->getStylePath() ) ) {
12		~~- $this->setStylePath( $wgScriptPath . '/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoColumnLetter4.css' );~~
	12	+ $this->setStylePath( $wgScriptPath . '/extensions/DonationInterface/gateway_forms/css/TwoColumnLetter4.css' );
13	13	}
14	14
15	15	parent::__construct( $form_data, $form_errors, $gateway );
Index: trunk/extensions/DonationInterface/gateway_forms/TwoColumnLetter5.php
—	—	@@ -7,7 +7,7 @@
8	8
9	9	// set the path to css, before the parent constructor is called, checking to make sure some child class hasn't already set this
10	10	if ( !strlen( $this->getStylePath() ) ) {
11		~~- $this->setStylePath( $wgScriptPath . '/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoColumnLetter5.css' );~~
	11	+ $this->setStylePath( $wgScriptPath . '/extensions/DonationInterface/gateway_forms/css/TwoColumnLetter5.css' );
12	12	}
13	13
14	14	parent::__construct( $form_data, $form_errors, $gateway );
Index: trunk/extensions/DonationInterface/gateway_forms/TwoColumnLetter6.php
—	—	@@ -7,7 +7,7 @@
8	8
9	9	// set the path to css, before the parent constructor is called, checking to make sure some child class hasn't already set this
10	10	if ( !strlen( $this->getStylePath() ) ) {
11		~~- $this->setStylePath( $wgScriptPath . '/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoColumnLetter6.css' );~~
	11	+ $this->setStylePath( $wgScriptPath . '/extensions/DonationInterface/gateway_forms/css/TwoColumnLetter6.css' );
12	12	}
13	13
14	14	parent::__construct( $form_data, $form_errors, $gateway );
Index: trunk/extensions/DonationInterface/gateway_forms/TwoColumnLetter7.php
—	—	@@ -7,7 +7,7 @@
8	8
9	9	// set the path to css, before the parent constructor is called, checking to make sure some child class hasn't already set this
10	10	if ( !strlen( $this->getStylePath() ) ) {
11		~~- $this->setStylePath( $wgScriptPath . '/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoColumnLetter7.css' );~~
	11	+ $this->setStylePath( $wgScriptPath . '/extensions/DonationInterface/gateway_forms/css/TwoColumnLetter7.css' );
12	12	}
13	13
14	14	parent::__construct( $form_data, $form_errors, $gateway );
Index: trunk/extensions/DonationInterface/gateway_forms/TwoStepTwoColumnLetterCA.php
—	—	@@ -6,7 +6,7 @@
7	7
8	8	// set the path to css, before the parent constructor is called, checking to make sure some child class hasn't already set this
9	9	if ( !strlen( $this->getStylePath() ) ) {
10		~~- $this->setStylePath( $wgScriptPath . '/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoStepTwoColumnLetter.css' );~~
	10	+ $this->setStylePath( $wgScriptPath . '/extensions/DonationInterface/gateway_forms/css/TwoStepTwoColumnLetter.css' );
11	11	}
12	12
13	13	parent::__construct( $form_data, $form_errors, $gateway );
Index: trunk/extensions/DonationInterface/gateway_forms/TwoColumnLetter.php
—	—	@@ -8,7 +8,7 @@
9	9
10	10	// set the path to css, before the parent constructor is called, checking to make sure some child class hasn't already set this
11	11	if ( !strlen( $this->getStylePath() ) ) {
12		~~- $this->setStylePath( $wgScriptPath . '/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoColumnLetter.css' );~~
	12	+ $this->setStylePath( $wgScriptPath . '/extensions/DonationInterface/gateway_form/css/TwoColumnLetter.css' );
13	13	}
14	14
15	15	parent::__construct( $form_data, $form_errors, $gateway );
Index: trunk/extensions/DonationInterface/gateway_forms/TwoStepTwoColumnLetter2.php
—	—	@@ -6,7 +6,7 @@
7	7
8	8	// set the path to css, before the parent constructor is called, checking to make sure some child class hasn't already set this
9	9	if ( !strlen( $this->getStylePath() ) ) {
10		~~- $this->setStylePath( $wgScriptPath . '/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoStepTwoColumnLetter2.css' );~~
	10	+ $this->setStylePath( $wgScriptPath . '/extensions/DonationInterface/gateway_forms/css/TwoStepTwoColumnLetter2.css' );
11	11	}
12	12
13	13	parent::__construct( $form_data, $form_errors, $gateway );
Index: trunk/extensions/DonationInterface/gateway_forms/TwoStepTwoColumnPremiumUS.php
—	—	@@ -6,7 +6,7 @@
7	7
8	8	// set the path to css, before the parent constructor is called, checking to make sure some child class hasn't already set this
9	9	if ( !strlen( $this->getStylePath() ) ) {
10		~~- $this->setStylePath( $wgScriptPath . '/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoStepTwoColumnPremiumUS.css' );~~
	10	+ $this->setStylePath( $wgScriptPath . '/extensions/DonationInterface/gateway_forms/css/TwoStepTwoColumnPremiumUS.css' );
11	11	}
12	12
13	13	parent::__construct( $form_data, $form_errors, $gateway );

Follow-up revisions

Revision	Commit summary	Author	Date
r100939	Followup r100619 fixing missing 's' in css pathname	awjrichards	03:10, 27 October 2011

Comments

#Comment by Khorn (WMF) (talk | contribs) 03:07, 27 October 2011

$this->setStylePath( $wgScriptPath . '/extensions/DonationInterface/gateway_form/css/TwoColumnLetter.css' );

...missing an 's' on the 'gateway_form' directory.

#Comment by Awjrichards (talk | contribs) 03:10, 27 October 2011

good catch. fixed in r100939

#Comment by Khorn (WMF) (talk | contribs) 03:12, 27 October 2011

Good Grief, that was fast. Oh, excuse me: "Rapid".

Status & tagging log

03:12, 27 October 2011 Khorn (WMF) (talk | contribs) changed the status of r100619 [removed: new added: ok]
03:10, 27 October 2011 Awjrichards (talk | contribs) changed the status of r100619 [removed: fixme added: new]
03:07, 27 October 2011 Khorn (WMF) (talk | contribs) changed the status of r100619 [removed: new added: fixme]
02:54, 27 October 2011 Jpostlethwaite (talk | contribs) changed the tags for r100619 [added: fundraising]