r100603 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100602‎ | r100603 | r100604 >
Date:13:16, 24 October 2011
Author:robin
Status:resolved (Comments)
Tags:
Comment:
(bug 31915) Narayam help page should be in content language
Modified paths:
  • /trunk/extensions/Narayam/Narayam.hooks.php (modified) (history)
  • /trunk/extensions/Narayam/js/ext.narayam.core.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Narayam/Narayam.hooks.php
@@ -48,6 +48,7 @@
4949
5050 $vars['wgNarayamAvailableSchemes'] = self::getSchemes(); // Note: scheme names must be keys, not values
5151 $vars['wgNarayamAllSchemes'] = $wgNarayamSchemes;
 52+ $vars['wgNarayamHelpPage'] = wfMsgForContent( 'narayam-help-page' );
5253 return true;
5354 }
5455
Index: trunk/extensions/Narayam/js/ext.narayam.core.js
@@ -551,7 +551,7 @@
552552 });
553553 } );
554554
555 - var helppage = mw.msg( 'narayam-help-page' );
 555+ var helppage = mw.config.get( 'wgNarayamHelpPage' );
556556 if ( helppage ) {
557557 $narayamMenuItems.append( $( '<li class="narayam-help-link" />')
558558 .append(
@@ -559,7 +559,7 @@
560560 .text( mw.msg( 'narayam-help' ) )
561561 .attr(
562562 'href',
563 - mw.util.wikiGetlink( mw.msg( 'narayam-help-page' ) )
 563+ mw.util.wikiGetlink( mw.config.get( 'wgNarayamHelpPage' ) )
564564 )
565565 )
566566 );

Follow-up revisions

RevisionCommit summaryAuthorDate
r100830(follow-up r100603) re-use variablerobin17:40, 26 October 2011
r101123Followup r100603. Remove narayam-help-page from wgResourceModules loading.santhosh08:44, 28 October 2011
r101368MFT r101320, r100603, r100830, r101123, r101256nikerabbit17:11, 31 October 2011

Comments

#Comment by Nikerabbit (talk | contribs)   06:44, 25 October 2011

Why isn't it reusing the helppage variable when constructing a link?

#Comment by Nikerabbit (talk | contribs)   06:06, 27 October 2011

Just realised that narayam-help-page should probably also be dropped from wgResourceModules loading.

Status & tagging log