r100581 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100580‎ | r100581 | r100582 >
Date:06:41, 24 October 2011
Author:raymond
Status:ok (Comments)
Tags:
Comment:
Per r100564: Register Fundraiser Landing Page
Alias file not added for translation. IIRC this special page is not visible for the user/reader.
Modified paths:
  • /trunk/translatewiki/MediaWiki/mediawiki-defines.txt (modified) (history)

Diff [purge]

Index: trunk/translatewiki/MediaWiki/mediawiki-defines.txt
@@ -594,6 +594,9 @@
595595 Front Back Matter Forced Wikilinks
596596 descmsg = frontbackforced-desc
597597
 598+Fundraiser Landing Page
 599+# Alias file not added for translation. IIRC this special page is not visible for the user/reader. Raymond 2011-10-24
 600+
598601 Gadgets
599602 aliasfile = Gadgets/Gadgets.alias.php
600603 ignored = gadgets-definition

Follow-up revisions

RevisionCommit summaryAuthorDate
r100613Followup r100564 per r100581 CR: fundraising -> fundraiserplatonides16:57, 24 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100564Poor FundraiserLandingPage had no messagesplatonides21:11, 23 October 2011

Comments

#Comment by Platonides (talk | contribs)   16:07, 24 October 2011

In which cases is a descmsg needed?

#Comment by Raymond (talk | contribs)   16:27, 24 October 2011

When extension name and description message key differ: In this case they are equal after some normalization by the Translate extension: Stripping spaces and lowercasing all: "Fundraiser Landing Page" -> "fundraiserlandingpage" .... wait...

Now I see why you ask: You named the message key: 'fundraisinglandingpage-desc'. That fails. Either rename the message key to 'fundraiserlandingpage-desc' or add a line with descmsg to mediawiki-defines.txt. For consistecy I prefer the first solution.

#Comment by Platonides (talk | contribs)   17:13, 24 October 2011

I was really askign because this knowledge doesn't seem documented anywhere (eg. at /trunk/translatewiki/README). Only a few ones really know how to completely add a extension/message. (FIXED)

Status & tagging log