r100536 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100535‎ | r100536 | r100537 >
Date:09:38, 23 October 2011
Author:aaron
Status:ok (Comments)
Tags:
Comment:
Use getId() accessors for Revision object (fixes fatal)
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -237,7 +237,7 @@
238238 wfMsgNoTrans( 'undo-success' ) . '</div>', true, /* interface */true );
239239 $firstrev = $oldrev->getNext();
240240 # If we just undid one rev, use an autosummary
241 - if ( $firstrev->mId == $undo ) {
 241+ if ( $firstrev->getId() == $undo ) {
242242 $undoSummary = wfMsgForContent( 'undo-summary', $undo, $undorev->getUserText() );
243243 if ( $this->summary === '' ) {
244244 $this->summary = $undoSummary;

Comments

#Comment by Hashar (talk | contribs)   16:36, 28 November 2011

Not happening in 1.18 since mId was set protected in 1.19 only.

Status & tagging log