r100508 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r100507‎ | r100508 | r100509 >
Date:18:52, 22 October 2011
Author:petrb
Status:deferred (Comments)
Tags:
Comment:
colored icon
Modified paths:
  • /trunk/extensions/OnlineStatusBar/OnlineStatusBar.body.php (modified) (history)
  • /trunk/extensions/OnlineStatusBar/OnlineStatusBar.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OnlineStatusBar/OnlineStatusBar.body.php
——@@ -22,9 +22,9 @@
2323
2424 public static function Get_Html( $text, $mode)
2525 {
26 - global $wgOnlineStatusBarModes, $wgOnlineStatusBarColor;
 26+ global $wgOnlineStatusBarModes, $wgOnlineStatusBarIcon, $wgOnlineStatusBarColor;
2727 $color= $wgOnlineStatusBarColor[$mode];
28 - return '<div style="border: 0px solid black; background: transparent; float: right; position: relative; top:-3px; padding: 5px"><p><b>' . $text . ': <span style="color: ' . $color . '; font:bold;"><img alt="Ledorange.svg" src="//upload.wikimedia.org/wikipedia/commons/thumb/5/5c/Ledorange.svg/20px-Ledorange.svg.png" width="20" height="20" />' . $wgOnlineStatusBarModes[$mode] . '</span></b></p></div>';
 28+ return '<div style="border: 0px solid black; background: transparent; float: right; position: relative; top:-3px; padding: 5px"><p><b>' . $text . ': <span style="color: ' . $color . '; font:bold;"><img alt="Ledorange.svg" src="' . $wgOnlineStatusBarIcon[$mode] . '" width="20" height="20" />' . $wgOnlineStatusBarModes[$mode] . '</span></b></p></div>';
2929 }
3030
3131 static function UpdateDb()
Index: trunk/extensions/OnlineStatusBar/OnlineStatusBar.php
——@@ -37,6 +37,14 @@
3838 'offline' => "Offline",
3939 );
4040
 41+$wgOnlineStatusBarIcon = array (
 42+ 'online' => "//upload.wikimedia.org/wikipedia/commons/thumb/c/cc/Ledgreen.svg/20px-Ledgreen.svg.png",
 43+ 'busy' => "//upload.wikimedia.org/wikipedia/commons/thumb/5/5c/Ledorange.svg/20px-Ledorange.svg.png",
 44+ 'away' => "//upload.wikimedia.org/wikipedia/commons/thumb/5/5c/Ledorange.svg/20px-Ledorange.svg.png",
 45+ 'hidden' => "//upload.wikimedia.org/wikipedia/commons/thumb/6/60/Nuvola_apps_krec.svg/20px-Nuvola_apps_krec.svg.png",
 46+ 'offline' => "//upload.wikimedia.org/wikipedia/commons/thumb/6/60/Nuvola_apps_krec.svg/20px-Nuvola_apps_krec.svg.png",
 47+);
 48+
4149 $wgOnlineStatusBarColor = array (
4250 'online' => "green",
4351 'busy' => "orange",

Comments

#Comment by Reach Out to the Truth (talk | contribs)   19:30, 22 October 2011

Using images directly from Commons could cause problems if the image is vandalized or renamed, or if upload.wikimedia.org goes down. Perhaps you could package them with the extension instead?

#Comment by Bawolff (talk | contribs)   19:40, 22 October 2011

Not to mention that MediaWiki is sometimes used in environments where the internet is not available.

Status & tagging log