r100490 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100489‎ | r100490 | r100491 >
Date:02:34, 22 October 2011
Author:reedy
Status:ok
Tags:
Comment:
REL1_18 MFT r97291, r98678
Modified paths:
  • /branches/REL1_18/phase3 (modified) (history)
  • /branches/REL1_18/phase3/includes (modified) (history)
  • /branches/REL1_18/phase3/includes/Exception.php (modified) (history)
  • /branches/REL1_18/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: branches/REL1_18/phase3/skins/common/shared.css
@@ -792,20 +792,6 @@
793793 right: 10px;
794794 background-position: 0% 100%;
795795 }
796 -/* Table Sorting */
797 -th.headerSort {
798 - background-image: url(images/sort_both.gif);
799 - cursor: pointer;
800 - background-repeat: no-repeat;
801 - background-position: center right;
802 - padding-right: 21px;
803 -}
804 -th.headerSortUp {
805 - background-image: url(images/sort_up.gif);
806 -}
807 -th.headerSortDown {
808 - background-image: url(images/sort_down.gif);
809 -}
810796
811797 /* LTR content in RTL layout */
812798 .ltr {
Index: branches/REL1_18/phase3/includes/Exception.php
@@ -150,7 +150,7 @@
151151 $line = $this->getLine();
152152 $message = $this->getMessage();
153153
154 - if ( isset( $wgRequest ) ) {
 154+ if ( isset( $wgRequest ) && !$wgRequest instanceof FauxRequest ) {
155155 $url = $wgRequest->getRequestURL();
156156 if ( !$url ) {
157157 $url = '[no URL]';
Property changes on: branches/REL1_18/phase3/includes
___________________________________________________________________
Modified: svn:mergeinfo
158158 Merged /trunk/phase3/includes:r97291
Property changes on: branches/REL1_18/phase3
___________________________________________________________________
Modified: svn:mergeinfo
159159 Merged /trunk/phase3:r97291,98678

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97291Don't attempt to get a request url from a FauxRequestdemon15:21, 16 September 2011
r98678Follow up r98665. And remove the old css of course.hartman16:10, 2 October 2011

Status & tagging log