r100463 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r100462‎ | r100463 | r100464 >
Date:22:01, 21 October 2011
Author:jpostlethwaite
Status:ok (Comments)
Tags:fundraising 
Comment:
Altering test form to handle bank transfer and real time bank transfer.
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_forms/TwoStepAmount.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_forms/TwoStepAmount.php
——@@ -26,7 +26,17 @@
2727 public function __construct( &$form_data, &$form_errors, &$gateway ) {
2828 global $wgOut;
2929
30 - $form_data['transaction_type'] = 'bt';
 30+ $form_data['payment_method'] = 'bt';
 31+ $form_data['payment_submethod'] = 'bt';
 32+
 33+ //$form_data['payment_method'] = 'rtbt';
 34+ //$form_data['payment_submethod'] = 'rtbt_nordea_sweeden';
 35+
 36+ //$form_data['payment_method'] = 'rtbt';
 37+ //$form_data['payment_submethod'] = 'rtbt_ideal';
 38+ //$form_data['issuerids'] = array();
 39+
 40+
3141 $form_data['process'] = 'other';
3242 parent::__construct( $form_data, $form_errors, $gateway );
3343

Comments

#Comment by Khorn (WMF) (talk | contribs)   02:54, 27 October 2011

This is a very slightly strange place to do this, but I can't come up with a reason it shouldn't be here in your test form for now. However, you should probably know that if you set these values in the adapter class... that's where $form_data in a form comes from in the first place. This is lot more obvious after I was able to refactor all the form constructors again. :)

Status & tagging log