r100408 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100407‎ | r100408 | r100409 >
Date:04:19, 21 October 2011
Author:jpostlethwaite
Status:ok (Comments)
Tags:fundraising 
Comment:
Documentation cleanup. Added public declarations to methods.
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_common/GatewayForm.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_common/GatewayForm.php
@@ -1,5 +1,25 @@
22 <?php
 3+/**
 4+ * Wikimedia Foundation
 5+ *
 6+ * LICENSE
 7+ *
 8+ * This program is free software; you can redistribute it and/or modify
 9+ * it under the terms of the GNU General Public License as published by
 10+ * the Free Software Foundation; either version 2 of the License, or
 11+ * (at your option) any later version.
 12+ *
 13+ * This program is distributed in the hope that it will be useful,
 14+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
 15+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 16+ * GNU General Public License for more details.
 17+ *
 18+ */
319
 20+/**
 21+ * GatewayForm
 22+ *
 23+ */
424 class GatewayForm extends UnlistedSpecialPage {
525
626 /**
@@ -26,12 +46,17 @@
2747
2848 /**
2949 * An array of form errors
30 - * @var array
 50+ * @var array $errors
3151 */
3252 public $errors = array( );
33 - public $adapter; //the adapter goes here.
3453
3554 /**
 55+ * The adapter object
 56+ * @var object $adapter
 57+ */
 58+ public $adapter;
 59+
 60+ /**
3661 * The form is assumed to be successful. Errors in the form must set this to
3762 * false.
3863 *
@@ -39,7 +64,11 @@
4065 */
4166 public $validateFormResult = true;
4267
43 - function __construct() {
 68+
 69+ /**
 70+ * Constructor
 71+ */
 72+ public function __construct() {
4473 $me = get_called_class();
4574 parent::__construct( $me );
4675 $this->errors = $this->getPossibleErrors();

Follow-up revisions

RevisionCommit summaryAuthorDate
r100409Getting rid of BANK_TRANSFER. Adding $transaction_groups and $transaction_types.jpostlethwaite04:23, 21 October 2011
r100410Changed transaction_type for hidden form element.jpostlethwaite04:47, 21 October 2011
r100411Removed BANK_TRANSFER as a transaction. Set it as a transaction type. Added t...jpostlethwaite04:52, 21 October 2011

Comments

#Comment by Jpostlethwaite (talk | contribs)   04:25, 21 October 2011

This is the beginning of a code checkin. More files to come.

#Comment by Jpostlethwaite (talk | contribs)   15:20, 24 October 2011

This code is ready for review.

Status & tagging log