r100373 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100372‎ | r100373 | r100374 >
Date:20:56, 20 October 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
REL1_18: MFT r98962, r98971, r99004, r99065
Modified paths:
  • /branches/REL1_18/phase3 (modified) (history)
  • /branches/REL1_18/phase3/includes (modified) (history)
  • /branches/REL1_18/phase3/includes/api (modified) (history)
  • /branches/REL1_18/phase3/includes/api/ApiQueryWatchlist.php (modified) (history)
  • /branches/REL1_18/phase3/includes/cache/MessageCache.php (modified) (history)
  • /branches/REL1_18/phase3/includes/specials (modified) (history)
  • /branches/REL1_18/phase3/includes/specials/SpecialEmailuser.php (modified) (history)
  • /branches/REL1_18/phase3/skins/Standard.php (modified) (history)

Diff [purge]

Index: branches/REL1_18/phase3/skins/Standard.php
@@ -109,11 +109,13 @@
110110 foreach ( $bar as $browseLinks ) {
111111 if ( $barnumber > 1 ) {
112112 $s .= "\n<hr class='sep' />";
113 - }
114 - foreach ( $browseLinks as $link ) {
115 - if ( $link['text'] != '-' ) {
116 - $s .= "<a href=\"{$link['href']}\">" .
117 - htmlspecialchars( $link['text'] ) . '</a>' . $sep;
 113+ }
 114+ if ( is_array( $browseLinks ) ) {
 115+ foreach ( $browseLinks as $link ) {
 116+ if ( $link['text'] != '-' ) {
 117+ $s .= "<a href=\"{$link['href']}\">" .
 118+ htmlspecialchars( $link['text'] ) . '</a>' . $sep;
 119+ }
118120 }
119121 }
120122 if ( $barnumber == 1 ) {
Index: branches/REL1_18/phase3/includes/api/ApiQueryWatchlist.php
@@ -295,7 +295,7 @@
296296 }
297297
298298 if ( $this->fld_parsedcomment && isset( $row->rc_comment ) ) {
299 - $vals['parsedcomment'] = $this->getSkin()->formatComment( $row->rc_comment, $title );
 299+ $vals['parsedcomment'] = Linker::formatComment( $row->rc_comment, $title );
300300 }
301301
302302 if ( $this->fld_loginfo && $row->rc_type == RC_LOG ) {
Property changes on: branches/REL1_18/phase3/includes/api
___________________________________________________________________
Modified: svn:mergeinfo
303303 Merged /branches/wmf/1.18wmf1/includes/api:r98962,98971,99004,99065
Property changes on: branches/REL1_18/phase3/includes/cache/MessageCache.php
___________________________________________________________________
Modified: svn:mergeinfo
304304 Merged /branches/wmf/1.18wmf1/includes/cache/MessageCache.php:r99065
Index: branches/REL1_18/phase3/includes/specials/SpecialEmailuser.php
@@ -122,7 +122,7 @@
123123 if( !$ret instanceof User ) {
124124 if( $this->mTarget != '' ) {
125125 $ret = ( $ret == 'notarget' ) ? 'emailnotarget' : ( $ret . 'text' );
126 - $out->wrapWikiMsg( "<p class='error'>$1</p>", $ret );
 126+ $wgOut->wrapWikiMsg( "<p class='error'>$1</p>", $ret );
127127 }
128128 $wgOut->addHTML( self::userForm( $this->mTarget ) );
129129 return false;
Property changes on: branches/REL1_18/phase3/includes/specials
___________________________________________________________________
Modified: svn:mergeinfo
130130 Merged /branches/wmf/1.18wmf1/includes/specials:r99004,99065
Property changes on: branches/REL1_18/phase3/includes
___________________________________________________________________
Modified: svn:mergeinfo
131131 Merged /branches/wmf/1.18wmf1/includes:r98962,98971,99004,99065
Property changes on: branches/REL1_18/phase3
___________________________________________________________________
Modified: svn:mergeinfo
132132 Merged /branches/wmf/1.18wmf1:r98962,98971,99004,99065

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98962Call to undefined method ApiQueryWatchlist::getSkin() in /usr/local/apache/co...reedy00:40, 5 October 2011
r98971Check if $browseLinks is an array as CologneBlue doesaaron01:42, 5 October 2011
r990041 PHP Fatal error: Call to a member function wrapWikiMsg() on a non-object i...reedy13:58, 5 October 2011
r99065Revert r92549, botched feature removal in REL1_18 causing a severe performanc...tstarling00:54, 6 October 2011

Comments

#Comment by Reedy (talk | contribs)   20:58, 20 October 2011

Looks like r99065 was already merged in somewhere

Status & tagging log