r100361 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100360‎ | r100361 | r100362 >
Date:19:01, 20 October 2011
Author:junaidpv
Status:ok (Comments)
Tags:
Comment:
Narayam: Fix undefined index issue in r100350.
Modified paths:
  • /trunk/extensions/Narayam/Narayam.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Narayam/Narayam.hooks.php
@@ -68,7 +68,9 @@
6969
7070 // Get user selected scheme from cookie
7171 // TODO: use $wgRequest;
72 - $lastScheme = $_COOKIE['narayam-scheme'];
 72+ $lastScheme = isset($_COOKIE['narayam-scheme'])
 73+ ? $_COOKIE['narayam-scheme']
 74+ : null;
7375 // If user selected scheme is not in the array of schemes to be loaded
7476 // Add it
7577 if ( $lastScheme && !array_key_exists( $lastScheme, $schemes ) ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r100412Use $wgRequest->getCookie instead of $_COOKIE.santhosh05:24, 21 October 2011
r102305MFT r99387 r99395 r99456 r99457 r99682 r99683 r100013 r100024 r100108 r100212...nikerabbit18:21, 7 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100350Narayam: Remember dynamically loaded scheme next time utilizing cookie entry....junaidpv15:41, 20 October 2011

Comments

#Comment by Santhosh.thottingal (talk | contribs)   05:30, 21 October 2011

r100412 changed $_COOKIE. to $wgRequest->getCookie

Status & tagging log