r100352 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100351‎ | r100352 | r100353 >
Date:17:13, 20 October 2011
Author:aaron
Status:ok (Comments)
Tags:
Comment:
Removed deprecated getFullPath(); no callers
Modified paths:
  • /trunk/phase3/includes/filerepo/File.php (modified) (history)
  • /trunk/phase3/includes/filerepo/LocalFile.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/LocalFile.php
@@ -872,7 +872,6 @@
873873 }
874874 }
875875
876 - /** getFullPath inherited */
877876 /** getHashPath inherited */
878877 /** getRel inherited */
879878 /** getUrlRel inherited */
Index: trunk/phase3/includes/filerepo/File.php
@@ -272,18 +272,6 @@
273273 }
274274
275275 /**
276 - * Alias for getPath()
277 - *
278 - * @deprecated since 1.18 Use getPath().
279 - *
280 - * @return string
281 - */
282 - public function getFullPath() {
283 - wfDeprecated( __METHOD__ );
284 - return $this->getPath();
285 - }
286 -
287 - /**
288276 * Return the width of the image. Returns false if the width is unknown
289277 * or undefined.
290278 *

Comments

#Comment by Hashar (talk | contribs)   12:20, 27 October 2011

I think we usually remove methods 2 versions after they got deprecated. Since that one is not in REL1_18 extension, I guess we are safe :-)

Status & tagging log